Closed Bug 1197146 Opened 9 years ago Closed 9 years ago

Convert assorted element commands in listener to use new dispatching technique

Categories

(Remote Protocol :: Marionette, defect)

Product:
Remote Protocol
Component:
Marionette
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(firefox42 affected, firefox43 fixed)

Status:
RESOLVED FIXED
Milestone:
mozilla43
Tracking Flags:
Tracking Status
firefox42 --- affected
firefox43 --- fixed

People

(Reporter: ato, Assigned: ato)

References

Details

(Keywords: pi-marionette-server)

Attachments

(8 files)

MozReview Request: Bug 1197146: Part 1: Prime dispatcher in listener to resolve promises
(deleted), text/x-review-board-request
automatedtester
: review+
Details
MozReview Request: Bug 1197146: Part 2: Use dispatcher for listener findElementsContent
(deleted), text/x-review-board-request
automatedtester
: review+
Details
MozReview Request: Bug 1197146: Part 3: Use dispatcher for listener findElementContent
(deleted), text/x-review-board-request
automatedtester
: review+
Details
MozReview Request: Bug 1197146: Part 4: Use dispatcher for listener isElementSelected
(deleted), text/x-review-board-request
automatedtester
: review+
Details
MozReview Request: Bug 1197146: Part 5: Use dispatcher for listener getElementLocation
(deleted), text/x-review-board-request
automatedtester
: review+
Details
MozReview Request: Bug 1197146: Part 6: Use dispatcher for listener clearElement
(deleted), text/x-review-board-request
automatedtester
: review+
Details
MozReview Request: Bug 1197146: Part 7: Use dispatcher for listener isElementDisplayed
(deleted), text/x-review-board-request
automatedtester
: review+
Details
MozReview Request: Bug 1197146: Part 8: Use dispatcher for listener getElementValueOfCssProperty
(deleted), text/x-review-board-request
automatedtester
: review+
Details
Assorted element commands implemented by listener not yet converted: - isElementDisplayed - getElementValueOfCssProperty - sendKeysToElement - getElementLocation - clearEleemnt - findElementContent - findElementsContent
Assignee: nobody → ato
Status: NEW → ASSIGNED
Summary: Convert listener assorted element commands to use new dispatching technique → Convert assorted element commands in listener to use new dispatching technique
Bug 1197146: Part 1: Prime dispatcher in listener to resolve promises Because of the asynchronous behaviour of some internal utilities, such as ElementManager, we need to employ promises to create a bridge over them and the synchronous returning functions. r=dburns
Attachment #8651058 - Flags: review?(dburns)
Bug 1197146: Part 2: Use dispatcher for listener findElementsContent r=dburns
Attachment #8651059 - Flags: review?(dburns)
Bug 1197146: Part 3: Use dispatcher for listener findElementContent r=dburns
Attachment #8651060 - Flags: review?(dburns)
Bug 1197146: Part 4: Use dispatcher for listener isElementSelected r=dburns
Attachment #8651061 - Flags: review?(dburns)
Bug 1197146: Part 5: Use dispatcher for listener getElementLocation r=dburns
Attachment #8651062 - Flags: review?(dburns)
Bug 1197146: Part 6: Use dispatcher for listener clearElement r=dburns
Attachment #8651063 - Flags: review?(dburns)
Bug 1197146: Part 7: Use dispatcher for listener isElementDisplayed r=dburns
Attachment #8651064 - Flags: review?(dburns)
Bug 1197146: Part 8: Use dispatcher for listener getElementValueOfCssProperty r=dburns
Attachment #8651065 - Flags: review?(dburns)
Blocks: 1197130
Attachment #8651058 - Flags: review?(dburns) → review+
Comment on attachment 8651058 [details] MozReview Request: Bug 1197146: Part 1: Prime dispatcher in listener to resolve promises https://reviewboard.mozilla.org/r/16833/#review15065 Ship It!
Comment on attachment 8651059 [details] MozReview Request: Bug 1197146: Part 2: Use dispatcher for listener findElementsContent https://reviewboard.mozilla.org/r/16835/#review15067 Ship It!
Attachment #8651059 - Flags: review?(dburns) → review+
Comment on attachment 8651060 [details] MozReview Request: Bug 1197146: Part 3: Use dispatcher for listener findElementContent https://reviewboard.mozilla.org/r/16837/#review15069 Ship It!
Attachment #8651060 - Flags: review?(dburns) → review+
Comment on attachment 8651061 [details] MozReview Request: Bug 1197146: Part 4: Use dispatcher for listener isElementSelected https://reviewboard.mozilla.org/r/16839/#review15071 Ship It!
Attachment #8651061 - Flags: review?(dburns) → review+
Comment on attachment 8651062 [details] MozReview Request: Bug 1197146: Part 5: Use dispatcher for listener getElementLocation https://reviewboard.mozilla.org/r/16841/#review15073 Ship It!
Attachment #8651062 - Flags: review?(dburns) → review+
Comment on attachment 8651063 [details] MozReview Request: Bug 1197146: Part 6: Use dispatcher for listener clearElement https://reviewboard.mozilla.org/r/16843/#review15075 Ship It!
Attachment #8651063 - Flags: review?(dburns) → review+
Comment on attachment 8651064 [details] MozReview Request: Bug 1197146: Part 7: Use dispatcher for listener isElementDisplayed https://reviewboard.mozilla.org/r/16845/#review15077 Ship It!
Attachment #8651064 - Flags: review?(dburns) → review+
Comment on attachment 8651065 [details] MozReview Request: Bug 1197146: Part 8: Use dispatcher for listener getElementValueOfCssProperty https://reviewboard.mozilla.org/r/16847/#review15079 Ship It!
Attachment #8651065 - Flags: review?(dburns) → review+
Please sir, can you uplift to aurora a=test-only
Flags: needinfo?(ryanvm)
Flags: needinfo?(ryanvm)
This probably needs http://hg.mozilla.org/integration/mozilla-inbound/rev/ba43a48d3c52 (bug 1191432) uplifted as well to work.
Flags: needinfo?(ato)
Product: Testing → Remote Protocol
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: