Adam Alldredge [:AdamA][Inactive] Reporter
	Description • 9 years ago

Description:
When the user receives a phone call on the lock screen and either denies the call, it times out, or it is ended by the other party the number will turn white and be very hard to read.

Repro Steps:
1) Update a Aries to 20150824130216
2) Lock phone
3) Receive a phone call
4) Deny the call or have the calling phone hang up
5) Observe calling number

Actual:
The phone number turns white when the phone call does not connect

Expected:
It is expected that the number is still clearly visible when the call does not connect

Environmental Variables:
Device: Aries 2.5 [Full Flash]
Build ID: 20150824130216
Gaia: d7fb5717d3e0153ac64af2c0d5c11079846d81c3
Gecko: ba43a48d3c52
Gonk: 2916e2368074b5383c80bf5a0fba3fc83ba310bd
Version: 43.0a1 (2.5)
Firmware Version: D5803_23.1.A.1.28_NCB.ftf
User Agent: Mozilla/5.0 (Mobile; rv:43.0) Gecko/43.0 Firefox/43.0

Repro frequency: 10/10
See attached: Screenshot, logcat

	Adam Alldredge [:AdamA][Inactive] Reporter
	Comment 1 • 9 years ago

This issue DOES occur on Flame 2.5, Flame 2.2, and Flame 2.1.

Environmental Variables:
Device: Flame 2.5 [Full Flash]
Build ID: 20150824030214
Gaia: cddb9f610cbe03d0ca39d81bbdce46a0fca841ab
Gecko: 8a6045d14d6b
Gonk: c4779d6da0f85894b1f78f0351b43f2949e8decd
Version: 43.0a1 (2.5)
Firmware Version: v18D
User Agent: Mozilla/5.0 (Mobile; rv:43.0) Gecko/43.0 Firefox/43.0

Device: Flame 2.2 [Full Flash]
Build ID: 20150821074640
Gaia: 335cd8e79c20f8d8e93a6efc9b97cc0ec17b5a46
Gecko: d29ec25e40e7
Gonk: bd9cb3af2a0354577a6903917bc826489050b40d
Version: 37.0 (2.2)
Firmware Version: v18D
User Agent: Mozilla/5.0 (Mobile; rv:37.0) Gecko/37.0 Firefox/37.0

Device: Flame 2.1 [Full Flash]
BuildID: 20150804032504
Gaia: f8b119ac30e97df991c97682ac4d4f9ca22e1793
Gecko: 0c7a85251e10
Gonk: bd9cb3af2a0354577a6903917bc826489050b40d
Version: 37.0 (2.2) 
Firmware Version: v18D
User Agent: Mozilla/5.0 (Mobile; rv:37.0) Gecko/37.0 Firefox/37.0

Result:
The phone number turns white when the phone call does not connect
-----------------------------
On Flame 2.0 the number disappears as soon as the call is not answered preventing me from checking this issue.

	Gabriele Svelto [:gsvelto] Assignee
	Comment 3 • 9 years ago

Looks like a regression to me, this used to work properly.

	Gabriele Svelto [:gsvelto] Assignee
	Comment 4 • 9 years ago

Double-checked, this isn't a regression, we turn the number white because normally when we hang up a call we display it against a red background but in the lockscreen the background stays white so maybe we shouldn't be changing the number's color when hanging up in the lockscreen, asking for UX feedback. Carol, what should we do in this scenario? Do we already have a design for how the hung up call should look in the lockscreen?

	Carol Huang [:Carol]
	Comment 5 • 9 years ago

Please help change the text to #ada9a7 (for hang up state) thanks!

	Gabriele Svelto [:gsvelto] Assignee
	Comment 6 • 9 years ago

Excellent, will do

	Tamara Hills [:thills]
	Comment 8 • 9 years ago

Comment on attachment 8688913 [details]
[gaia] gabrielesvelto:bug-1198051-lockscreen-hangup-call-fix > mozilla-b2g:master

Hi Gabriele,

Sorry for the delay.  This looks good and works for me.

Thanks,

-tamara

	Gabriele Svelto [:gsvelto] Assignee
	Comment 9 • 9 years ago

Thanks Tamara; merged to gaia/master bba9403aee039f76f4a0df80293744c982c99fe4

https://github.com/mozilla-b2g/gaia/commit/bba9403aee039f76f4a0df80293744c982c99fe4

	helen（leave from Mozilla）
	Comment 10 • 9 years ago

This bug has been verified as "pass" on the latest build of Aries kk master & Flame KK master by the STR in comment 0.
Actual results: The number is still visible rather than turns white when the call does not connect.

See attachment: Verified_number visible.png
Reproduce rate: 0/10

Device: Flame KK master 512mb( Pass )
Build ID               20151217150205
Gaia Revision          140f6ee998b07b354d1841fed902056179c90100
Gaia Date              2015-12-16 23:09:21
Gecko Revision         https://hg.mozilla.org/mozilla-central/rev/f143af51f6e35932927b8ccac2509facbbe7b539
Gecko Version          46.0a1
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.cltbld.20151217.182817
Firmware Date          Thu Dec 17 18:28:30 EST 2015
Firmware Version       v18D v4
Bootloader             L1TC000118D0

Device: Aries KK master ( Pass )
Build ID               20151217120654
Gaia Revision          140f6ee998b07b354d1841fed902056179c90100
Gaia Date              2015-12-16 23:09:21
Gecko Revision         https://hg.mozilla.org/mozilla-central/rev/0711218a018d912036f7d3be2ae2649e213cfb85
Gecko Version          46.0a1
Device Name            aries
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.worker.20151217.112618
Firmware Date          Thu Dec 17 11:26:26 UTC 2015
Bootloader             s1