Closed Bug 1198244 Opened 9 years ago Closed 9 years ago

Audit multi-line addEventListener...bind( callers for leaking/broken add/removeEventListener pairs

Categories

(Firefox :: General, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
Tracking Status
firefox43 --- affected

People

(Reporter: Gijs, Assigned: Gijs)

References

Details

Went through until the end of the devtools list, filed one bug about a duplicate bind(), didn't find anything else so far.
Flags: needinfo?(gijskruitbosch+bugs)
browser/extensions/pdfjs/content/web/viewer.js: element.addEventListener('click', elements[item].handler.bind(this)); browser/extensions/pdfjs/content/web/viewer.js: toggleHandTool.addEventListener('click', this.toggle.bind(this), false); browser/extensions/pdfjs/content/web/viewer.js: this.passwordSubmit.addEventListener('click', this.verifyPassword.bind(this)); browser/extensions/pdfjs/content/web/viewer.js: this.passwordCancel.addEventListener('click', this.close.bind(this)); browser/extensions/pdfjs/content/web/viewer.js: options.closeButton.addEventListener('click', this.close.bind(this)); browser/extensions/pdfjs/content/web/viewer.js: document.getElementById('presentationMode').addEventListener('click', SecondaryToolbar.presentationModeClick.bind(SecondaryToolbar)); browser/extensions/pdfjs/content/web/viewer.js: document.getElementById('openFile').addEventListener('click', SecondaryToolbar.openFileClick.bind(SecondaryToolbar)); browser/extensions/pdfjs/content/web/viewer.js: document.getElementById('print').addEventListener('click', SecondaryToolbar.printClick.bind(SecondaryToolbar)); browser/extensions/pdfjs/content/web/viewer.js: document.getElementById('download').addEventListener('click', SecondaryToolbar.downloadClick.bind(SecondaryToolbar)); browser/extensions/shumway/content/shumway.gfx.js: window.addEventListener("resize", this._onResize.bind(this)); browser/extensions/shumway/content/shumway.gfx.js: window.addEventListener("resize", this._resizeHandler.bind(this), !1); browser/extensions/shumway/content/shumway.gfx.js: this._easel.addEventListener("resize", this._resizeEventListener.bind(this)); browser/extensions/shumway/content/shumway.player.js: window.addEventListener("resize", this._onResize.bind(this)); browser/extensions/shumway/content/shumway.player.js: window.addEventListener("resize", this._resizeHandler.bind(this), !1); browser/extensions/shumway/content/shumway.player.js: this._mediaSource.addEventListener("sourceopen", this._openMediaSource.bind(this)); browser/extensions/shumway/content/shumway.player.js: q.addEventListener(e.OPEN, this.onStreamOpen.bind(this)); browser/extensions/shumway/content/shumway.player.js: q.addEventListener(e.COMPLETE, this.onStreamComplete.bind(this)); browser/extensions/shumway/content/shumway.player.js: q.addEventListener(d.PROGRESS, this.onStreamProgress.bind(this)); browser/extensions/shumway/content/shumway.player.js: q.addEventListener(l.IO_ERROR, this.onStreamIOError.bind(this)); browser/extensions/shumway/content/shumway.player.js: q.addEventListener(a.HTTP_STATUS, this.onStreamHTTPStatus.bind(this)); browser/extensions/shumway/content/shumway.player.js: q.addEventListener(a.HTTP_RESPONSE_STATUS, this.onStreamHTTPResponseStatus.bind(this)); browser/extensions/shumway/content/shumway.player.js: q.addEventListener(c.SECURITY_ERROR, this.onStreamSecurityError.bind(this)); browser/extensions/shumway/content/shumway.player.js: d.addEventListener("addedToStage", this._addListeners.bind(this)); browser/extensions/shumway/content/shumway.player.js: d.addEventListener("removedFromStage", this._removeListeners.bind(this)); browser/extensions/shumway/content/shumway.player.js: this._loader.contentLoaderInfo.addEventListener(n.events.Event.OPEN, this.openHandler.bind(this)); browser/extensions/shumway/content/shumway.player.js: this._loader.contentLoaderInfo.addEventListener(n.events.ProgressEvent.PROGRESS, this.progressHandler.bind(this)); browser/extensions/shumway/content/shumway.player.js: this._loader.contentLoaderInfo.addEventListener(n.events.IOErrorEvent.IO_ERROR, this.ioErrorHandler.bind(this)); browser/extensions/shumway/content/shumway.player.js: this._loader.contentLoaderInfo.addEventListener(n.events.Event.COMPLETE, this.completeHandler.bind(this)); browser/extensions/shumway/content/shumway.player.js: this._loader.contentLoaderInfo.addEventListener(n.events.Event.INIT, this.initHandler.bind(this)); toolkit/components/passwordmgr/content/passwordManager.js: treecols.addEventListener("click", HandleTreeColumnClick.bind(null, SignonColumnSort)); toolkit/components/passwordmgr/content/passwordManagerExceptions.js: treecols.addEventListener("click", HandleTreeColumnClick.bind(null, RejectColumnSort)); toolkit/components/prompts/content/tabprompts.xml: this.ui.button0.addEventListener("command", this.onButtonClick.bind(this, 0), false); toolkit/components/prompts/content/tabprompts.xml: this.ui.button1.addEventListener("command", this.onButtonClick.bind(this, 1), false); toolkit/components/prompts/content/tabprompts.xml: this.ui.button2.addEventListener("command", this.onButtonClick.bind(this, 2), false); toolkit/components/prompts/content/tabprompts.xml: this.ui.button3.addEventListener("command", this.onButtonClick.bind(this, 3), false); toolkit/components/search/SearchSuggestionController.jsm: this._request.addEventListener("load", this._onRemoteLoaded.bind(this, deferredResponse)); toolkit/components/viewsource/content/viewSourceUtils.js: webNavigation.document.addEventListener("DOMContentLoaded", this.onContentLoaded.bind(this)); toolkit/content/aboutwebrtc/aboutWebrtc.js: ctrl.addEventListener("click", this.onClick.bind(this)); toolkit/mozapps/extensions/content/setting.xml: this.control.addEventListener("command", this.inputChanged.bind(this), false);
Flags: needinfo?(gijskruitbosch+bugs)
Depends on: 1198941
Annnd we're done.
Assignee: nobody → gijskruitbosch+bugs
Status: NEW → RESOLVED
Closed: 9 years ago
No longer depends on: 1198941
Flags: needinfo?(gijskruitbosch+bugs)
Resolution: --- → FIXED
Depends on: 1198941
You need to log in before you can comment on or make changes to this bug.