Closed
Bug 1198547
Opened 9 years ago
Closed 9 years ago
Update sidebar background color for Win10
Categories
(Firefox :: Theme, defect, P3)
Tracking
()
VERIFIED
FIXED
Firefox 43
People
(Reporter: Dolske, Assigned: dao)
References
Details
(Whiteboard: [testday-20150901])
Attachments
(1 file)
|
(deleted),
patch
|
jaws
:
review+
ritu
:
approval-mozilla-aurora+
ritu
:
approval-mozilla-beta+
|
Details | Diff | Splinter Review |
The bookmark/history sidebar background color has a light blueish tint. This color seems out of place to me on Windows 10. Seems like it should either be white or the same color as the navbar?
|
Reporter | |
Updated•9 years ago
|
Flags: needinfo?(shorlander)
|
|
Reporter | |
Updated•9 years ago
|
Blocks: theme-win10
|
Assignee | |
Comment 1•9 years ago
|
||
Yes, the blue was specifically picked for Vista. Should be an easy fix.
Assignee: nobody → dao
Blocks: 1192839
OS: Unspecified → Windows 10
Priority: -- → P3
Summary: Update sidebar background color for Win10? → Update sidebar background color for Win10
|
|
Assignee | |
Comment 2•9 years ago
|
||
Attachment #8652872 -
Flags: review?(dolske)
|
||
Updated•9 years ago
|
Attachment #8652872 -
Flags: review?(dolske) → review+
|
||
Comment 4•9 years ago
|
||
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 43
|
|
Assignee | |
Updated•9 years ago
|
Flags: needinfo?(shorlander) → qe-verify+
|
|
Assignee | |
Comment 5•9 years ago
|
||
Comment on attachment 8652872 [details] [diff] [review]
patch
Approval Request Comment
[Feature/regressing bug #]: Windows 10 release
[User impact if declined]: see comment 0
[Describe test coverage new/current, TreeHerder]:
[Risks and why]: very simple styling change, low risk
[String/UUID change made/needed]:
Attachment #8652872 -
Flags: approval-mozilla-beta?
Attachment #8652872 -
Flags: approval-mozilla-aurora?
|
||
Updated•9 years ago
|
status-firefox41:
--- → affected
status-firefox42:
--- → affected
Comment on attachment 8652872 [details] [diff] [review]
patch
Seems like a safe change to uplift to Aurora and Beta. It would be much harder to uplift such changes, a week from now when Beta41 cycle enters it's end game.
Attachment #8652872 -
Flags: approval-mozilla-beta?
Attachment #8652872 -
Flags: approval-mozilla-beta+
Attachment #8652872 -
Flags: approval-mozilla-aurora?
Attachment #8652872 -
Flags: approval-mozilla-aurora+
|
|
||
Comment 7•9 years ago
|
||
|
|
||
Comment 8•9 years ago
|
||
|
||
Comment 9•9 years ago
|
||
Verified as fixed on Windows 10 64bit with Firefox 41.0b6 (20150831172306) while still bluish on Firefox 40.0.3 (20150826023504).
Status: RESOLVED → VERIFIED
Whiteboard: [testday-20150901]
|
||
Comment 10•9 years ago
|
||
I was able to reproduce this issue on Firefox 43.0a1 (2015-08-25) under Windows 10 32-bit.
Verified fixed on Firefox 43.0a1 (2015-09-01), Firefox 42.0a2 (2015-09-01) and Firefox 41 Beta 6 (20150831172306) under Windows 10 32-bit.
And also many thanks Jerod Lycett for your testing!
You need to log in
before you can comment on or make changes to this bug.
Description
•