Randell Jesup [:jesup] (needinfo me) Assignee
	Description • 9 years ago

+++ This bug was initially created as a clone of Bug #1194817 +++

From bug 1194817 comment 11:
> Coverity complains about this patch:
> CID 1320439 (#1 of 1): Logical vs. bitwise operator
> (CONSTANT_EXPRESSION_RESULT)logical_vs_bitwise: paddrparams.spp_flags &= 0U /* !8 */ always assigns 0 to paddrparams.spp_flags.
>    Did you intend to use '~' rather than '!'?

yes, it should be ~

	Randell Jesup [:jesup] (needinfo me) Assignee
	Comment 2 • 9 years ago

Wow, that was fast.  :-)

	Pulsebot
	Comment 3 • 9 years ago

https://hg.mozilla.org/integration/mozilla-inbound/rev/dda56b1c5210

	Michael Tüxen
	Comment 4 • 9 years ago

Sitting in a meeting...

	Sylvestre Ledru [:Sylvestre]
	Comment 5 • 9 years ago

Tracked for 41 to make sure we don't forget the uplift (but knowing Randell, I know this won't be necessary)

	Randell Jesup [:jesup] (needinfo me) Assignee
	Comment 6 • 9 years ago

Comment on attachment 8652836 [details] [diff] [review]
fix simple bug in PMTUD disable that clears all other flags

Approval Request Comment
[Feature/regressing bug #]: bug 1194817

[User impact if declined]: Kills the heartbeat, which catches (eventually) link failure.  Lack of heartbeat will not cause major loss of functionality, however.

[Describe test coverage new/current, TreeHerder]: DataChannels are hit in testing

[Risks and why]: virtually no risk
Note: there's an upstream bug with the spp flags reported by sctp_getopt() that could cause problem if we *later* did getopt/setopt on a different flag; however we don't do that (confirmed with GDB), so confirmed working and safe in operation.

[String/UUID change made/needed]: none

	Ryan VanderMeulen [:RyanVM]
	Comment 7 • 9 years ago

https://hg.mozilla.org/mozilla-central/rev/dda56b1c5210

	Ritu Kothari (:ritu) (Inactive, please n-i to RyanVM, jcristau, or pascal)
	Comment 8 • 9 years ago

Comment on attachment 8652836 [details] [diff] [review]
fix simple bug in PMTUD disable that clears all other flags

Safe to uplift to Beta and Aurora. Nice to this was caught by Coverity's static code analysis.

	Ryan VanderMeulen [:RyanVM]
	Comment 9 • 9 years ago

https://hg.mozilla.org/releases/mozilla-aurora/rev/50d43aa31d3d

	Ryan VanderMeulen [:RyanVM]
	Comment 10 • 9 years ago

https://hg.mozilla.org/releases/mozilla-beta/rev/2be849821652