Henri Sivonen (:hsivonen) (away from Bugzilla until 2023-09-11) Assignee
	Description • 9 years ago

nsIUnicodeEncoder::SetOutputErrorBehavior() takes three arguments:
1) Behavior enum
2) An nsIUnicharEncoder to be used with the kOnError_CallBack behavior
3) A replacement character to be used with the kOnError_Replace behavior

We should remove the second argument as well as the kOnError_CallBack enum item, since they are never used--not even in in c-c: 
https://mxr.mozilla.org/comm-central/ident?i=SetOutputErrorBehavior . This would allow us to remove nsIUnicharEncoder and all its implementations.

We should remove the third argument, because it is always set to '?' in non-test code where it is not ignored (i.e. when behavior is kOnError_Replace). We should simply hard-code the ASCII question mark as the replacement character when kOnError_Replace is in use.

	Henri Sivonen (:hsivonen) (away from Bugzilla until 2023-09-11) Assignee
	Comment 1 • 9 years ago

See https://mxr.mozilla.org/comm-central/ident?i=kOnError_CallBack for non-use.

	Henri Sivonen (:hsivonen) (away from Bugzilla until 2023-09-11) Assignee
	Comment 2 • 7 years ago

Fixed by bug 1261841.