Closed
Bug 1198935
Opened 9 years ago
Closed 9 years ago
Set about: pages header height to 48px
Categories
(Firefox for Android Graveyard :: Theme and Visual Design, defect)
Tracking
(firefox48 verified)
VERIFIED
FIXED
Firefox 48
Tracking | Status | |
---|---|---|
firefox48 | --- | verified |
People
(Reporter: antlam, Assigned: ralin)
References
Details
Attachments
(3 files)
I noticed our headers in the about:logins, about:addons, etc, are taller than in the spec. Let's update these and see how they look!
Reporter | ||
Updated•9 years ago
|
Blocks: about-improvements, fennec-polish
Assignee | ||
Updated•9 years ago
|
Assignee: nobody → ralin
Assignee | ||
Comment 1•9 years ago
|
||
Hi, Anthony. I've made some changes in the screenshot: 1. change border color 2. set fixed height(48px) for header 3. made right hand side button to 48px square Could you give me some feedback? Thanks
Attachment #8741256 -
Flags: feedback?(alam)
Reporter | ||
Comment 2•9 years ago
|
||
Comment on attachment 8741256 [details]
header_output.png
Looks great, thanks Ray!
Attachment #8741256 -
Flags: feedback?(alam) → feedback+
Assignee | ||
Comment 3•9 years ago
|
||
Review commit: https://reviewboard.mozilla.org/r/46463/diff/#index_header See other reviews: https://reviewboard.mozilla.org/r/46463/
Attachment #8741399 -
Flags: review?(a.m.naaktgeboren)
Comment 4•9 years ago
|
||
Comment on attachment 8741399 [details] MozReview Request: Bug 1198935 - Set about: pages header height to 48px. r?margaret https://reviewboard.mozilla.org/r/46463/#review43043 I'm not sure if ally is still active in Bugzilla. This looks good to me, so I'll steal the review and give this an r+!. ::: mobile/android/themes/core/aboutBase.css:41 (Diff revision 1) > } > > .header > div { > flex: 1; > padding: 1em; > - -moz-padding-start: 1.5em; > + -moz-padding-start: 16px; It's odd to have inconsistency between em and px. Can we change the generic padding rule to px as well?
Attachment #8741399 -
Flags: review+
Assignee | ||
Comment 5•9 years ago
|
||
Comment on attachment 8741399 [details] MozReview Request: Bug 1198935 - Set about: pages header height to 48px. r?margaret Review request updated; see interdiff: https://reviewboard.mozilla.org/r/46463/diff/1-2/
Attachment #8741399 -
Attachment description: MozReview Request: Bug 1198935 - Set about: pages header height to 48px. r?ally → MozReview Request: Bug 1198935 - Set about: pages header height to 48px. r?Margaret
Attachment #8741399 -
Flags: review?(a.m.naaktgeboren)
Assignee | ||
Comment 6•9 years ago
|
||
Comment on attachment 8741399 [details] MozReview Request: Bug 1198935 - Set about: pages header height to 48px. r?margaret Review request updated; see interdiff: https://reviewboard.mozilla.org/r/46463/diff/2-3/
Attachment #8741399 -
Attachment description: MozReview Request: Bug 1198935 - Set about: pages header height to 48px. r?Margaret → MozReview Request: Bug 1198935 - Set about: pages header height to 48px. r?margaret
Assignee | ||
Comment 7•9 years ago
|
||
https://reviewboard.mozilla.org/r/46463/#review43043 > It's odd to have inconsistency between em and px. Can we change the generic padding rule to px as well? No problem! I changed generic padding to 10px, and it looks no difference to 1em in this case. Thanks.
Comment 10•9 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/cfdf31074891
Status: NEW → RESOLVED
Closed: 9 years ago
status-firefox48:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 48
Comment 11•8 years ago
|
||
Verified as fixed in build 48.0a2 2016-05-30; Device: LG G4 (Android 5.1).
Status: RESOLVED → VERIFIED
Updated•4 years ago
|
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•