Closed Bug 1199138 Opened 9 years ago Closed 9 years ago

We have two ways to add context to a conversation

Categories

(Hello (Loop) :: Client, defect, P3)

Product:
Hello (Loop)
Component:
Client
Type:
defect

Tracking

(firefox42 unaffected, firefox43 affected)

Status:
RESOLVED FIXED
Milestone:
mozilla44
Iteration:
44.1 - Oct 5
Tracking Flags:
Tracking Status
firefox42 --- unaffected
firefox43 --- affected

People

(Reporter: bmaris, Unassigned)

References

Details

(Whiteboard: [visual refresh][fixed by bug 1184924])

User Story

Todo:

- Check for possible conflicts with work in bug 1184924.
- Remove the existing "Add some context" link, string and image.
- In the Cog menu, when there's no context, change the "Edit context" item to "Add context".
Affected builds: - latest Nightly 43.0a1 Affected OS`s: - Windows 7 32-bit - Mac OS X 10.10.4 - Ubuntu 14.04 32-bit STR: 1. Start Firefox 2. Start a conversation without context Expected results: Based on mockup from bug 1179164 only Edit button is available to add context. Actual results: There are two ways to add context;'Add some context' and Edit button. Notes: 1. This is not a regression, it was introduced once the edit button was moved to conversation toolbar, bug 1171940. 2. I don`t know if what is the plan with this but here are two possible solutions I can think of: - remove 'Add some context'. Edit button will do the job but will be confusing for first users. - don`t make Edit button visible if the conversation starts with is no context, make it visible only when context has been added.
just make sure we match visual refresh for invite and should fix bug. Sevaan - related UX question - in the new Invitation View (where it says invite to join you and no one else in room - there is not option to add Context)
Blocks: 1179164
Rank: 19
Flags: needinfo?(sfranks)
Priority: -- → P1
Whiteboard: [context bug] → [visual refresh]
That option should be in the gear menu http://i.sevaan.com/image/0q2b141H2a3t
Flags: needinfo?(sfranks)
Sevaan: The current menu item is "Edit Context" should we use "Add Context" or something else?
User Story: (updated)
Depends on: 1184924
Flags: needinfo?(sfranks)
My thinking was that the phrase "Edit context" appears when context is already attached, and the person has the option to change it. For rooms without context "Add context" would appear. However, this could be very low priority as "Edit Context" still, technically, applies.
Flags: needinfo?(sfranks)
Rank: 19 → 31
Priority: P1 → P3
This has been fixed by bug 1184924
Status: NEW → RESOLVED
Closed: 9 years ago
status-firefox42: affected → unaffected
Resolution: --- → FIXED
Whiteboard: [visual refresh] → [visual refresh][fixed by bug 1184924]
Target Milestone: --- → mozilla44
Iteration: --- → 44.1 - Oct 5
You need to log in before you can comment on or make changes to this bug.