It looks like we've never inlined heavyweight functions, but this restriction is probably from the JM days and not really necessary anymore. There are plenty of heavyweight, small functions with lambdas where inlining is beneficial. This should improve some of the sixspeed arrow-declare tests a lot. Locally it also wins at least a few hundred points on Octane earley-boyer.

Comment on attachment 8653359 [details] [diff] [review] Patch Review of attachment 8653359 [details] [diff] [review]: ----------------------------------------------------------------- ::: js/src/jit-test/tests/debug/optimized-out-01.js @@ +26,5 @@ > }; > > + g.eval("" + function f(d, x) { > + "use strict"; > + eval("g(d, x)"); // `eval` to avoid inlining g. I'll fix the indentation here to match the rest of the file (2 instead of 4 spaces).

This one also removes TrackedOutcome::CantInlineHeavyweight.

Comment on attachment 8653359 [details] [diff] [review] Patch Review of attachment 8653359 [details] [diff] [review]: ----------------------------------------------------------------- A++++ would review again

Comment on attachment 8653363 [details] [diff] [review] Patch Review of attachment 8653363 [details] [diff] [review]: ----------------------------------------------------------------- A+++++ would also review again