Closed
Bug 1199519
Opened 9 years ago
Closed 9 years ago
Remove usage of :-moz-full-screen-ancestor from our CSS code
Categories
(Core :: CSS Parsing and Computation, defect)
Core
CSS Parsing and Computation
Tracking
()
RESOLVED
FIXED
mozilla47
People
(Reporter: xidorn, Assigned: xidorn)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
(deleted),
patch
|
mixedpuppy
:
review+
|
Details | Diff | Splinter Review |
It seems :-moz-full-screen-ancestor is from some old revision of the Fullscreen API, and with the top layer concept and ::backdrop pseudo-element, this should no longer useful.
When we finish implementing top layer and ::backdrop, we should remove this from our CSS code ,and probably also make a perf to disable it to see whether it causes any site-compatibility issue.
Comment hidden (obsolete) |
Comment hidden (obsolete) |
Comment hidden (obsolete) |
Assignee | ||
Updated•9 years ago
|
Summary: Remove usage of :-moz-full-screen-ancestor from our CSS code and determine whether we need to keep that selector → Remove usage of :-moz-full-screen-ancestor from our CSS code
Assignee | ||
Comment 4•9 years ago
|
||
Not really depends on ::backdrop. No rule in our codebase depends on the background.
No longer depends on: ::backdrop
Assignee | ||
Comment 5•9 years ago
|
||
It seems to me currently for some reason, the in-browser chatbar actually cannot enter fullscreen (probably a regression of some fullscreen code change), so I just remove the code for that case.
If we think allowing in-browser chatbox to enter fullscreen is important, we may handle that in some other bug, which needs to fix the deeper issue here.
Assignee: nobody → quanxunzhen
Attachment #8701685 -
Flags: review?(felipc)
Assignee | ||
Updated•9 years ago
|
Comment 6•9 years ago
|
||
Adding dev-doc-needed to double check we have no docs about this one on MDN (and if so to update them)
Keywords: dev-doc-needed
Comment 7•9 years ago
|
||
Comment on attachment 8701685 [details] [diff] [review]
patch
Code change looks fine, but I don't know what is the current state of the Social API. Better check with someone who knows it. Sending the review to Shane.
Attachment #8701685 -
Flags: review?(felipc) → review?(mixedpuppy)
Comment 8•9 years ago
|
||
Hello is the primary user of the chat window, my guess is that they will not want this functionality broken, but better to ask them...
Flags: needinfo?(standard8)
Comment 9•9 years ago
|
||
Comment on attachment 8701685 [details] [diff] [review]
patch
hello behavior doesn't change with this patch, r=me and landing.
Flags: needinfo?(standard8)
Attachment #8701685 -
Flags: review?(mixedpuppy) → review+
Comment 10•9 years ago
|
||
https://hg.mozilla.org/integration/fx-team/rev/d16bb239c89373b0cc1c4ecf40e6ffc88971867c
Bug 1199519 - Remove :-moz-full-screen-ancestor use in our own code, r=mixedpuppy
Comment 11•9 years ago
|
||
bugherder |
Status: NEW → RESOLVED
Closed: 9 years ago
status-firefox47:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla47
Updated•9 years ago
|
Keywords: dev-doc-needed
You need to log in
before you can comment on or make changes to this bug.
Description
•