Closed Bug 1199519 Opened 9 years ago Closed 9 years ago

Remove usage of :-moz-full-screen-ancestor from our CSS code

Categories

(Core :: CSS Parsing and Computation, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla47
Tracking Status
firefox43 --- affected
firefox47 --- fixed

People

(Reporter: xidorn, Assigned: xidorn)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

It seems :-moz-full-screen-ancestor is from some old revision of the Fullscreen API, and with the top layer concept and ::backdrop pseudo-element, this should no longer useful. When we finish implementing top layer and ::backdrop, we should remove this from our CSS code ,and probably also make a perf to disable it to see whether it causes any site-compatibility issue.
Blocks: 1199529
Depends on: 1201798
Blocks: 743198
Summary: Remove usage of :-moz-full-screen-ancestor from our CSS code and determine whether we need to keep that selector → Remove usage of :-moz-full-screen-ancestor from our CSS code
Not really depends on ::backdrop. No rule in our codebase depends on the background.
No longer depends on: ::backdrop
Attached patch patch (deleted) — Splinter Review
It seems to me currently for some reason, the in-browser chatbar actually cannot enter fullscreen (probably a regression of some fullscreen code change), so I just remove the code for that case. If we think allowing in-browser chatbox to enter fullscreen is important, we may handle that in some other bug, which needs to fix the deeper issue here.
Assignee: nobody → quanxunzhen
Attachment #8701685 - Flags: review?(felipc)
Adding dev-doc-needed to double check we have no docs about this one on MDN (and if so to update them)
Keywords: dev-doc-needed
Comment on attachment 8701685 [details] [diff] [review] patch Code change looks fine, but I don't know what is the current state of the Social API. Better check with someone who knows it. Sending the review to Shane.
Attachment #8701685 - Flags: review?(felipc) → review?(mixedpuppy)
Hello is the primary user of the chat window, my guess is that they will not want this functionality broken, but better to ask them...
Flags: needinfo?(standard8)
No longer blocks: 743198
Comment on attachment 8701685 [details] [diff] [review] patch hello behavior doesn't change with this patch, r=me and landing.
Flags: needinfo?(standard8)
Attachment #8701685 - Flags: review?(mixedpuppy) → review+
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla47
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: