Closed
Bug 1199805
Opened 9 years ago
Closed 9 years ago
Origin is no longer shown on some site permission prompts
Categories
(Firefox :: General, defect, P1)
Firefox
General
Tracking
()
Tracking | Status | |
---|---|---|
firefox41 | --- | unaffected |
firefox42 | + | fixed |
firefox43 | --- | fixed |
People
(Reporter: MattN, Assigned: MattN)
References
Details
(Keywords: regression, Whiteboard: [fxprivacy])
Attachments
(1 file)
(deleted),
text/x-review-board-request
|
bgrins
:
review+
Sylvestre
:
approval-mozilla-aurora+
|
Details |
Site permission prompts stopped showing the origin since an instance of displayOrigin wasn't replaced with displayURI.
[Tracking Requested - why for this release]: Security UI Regression
Regressed by bug 1175300 (my fault in a rebase probably).
I have a trivial patch but need to write a test to prevent this in the future.
Flags: qe-verify-
Assignee | ||
Comment 1•9 years ago
|
||
Bug 1199805 - Fix displayURI typo on site permission prompts. r=bgrins
One instance of displayOrigin wasn't renamed to displayURI.
Attachment #8654365 -
Flags: review?(bgrinstead)
Comment 2•9 years ago
|
||
Comment on attachment 8654365 [details]
MozReview Request: Bug 1199805 - Fix displayURI typo on site permission prompts. r=bgrins
https://reviewboard.mozilla.org/r/17665/#review15811
Please add tests in another patch before pushing
Attachment #8654365 -
Flags: review?(bgrinstead) → review+
Updated•9 years ago
|
Updated•9 years ago
|
Iteration: 43.2 - Sep 7 → 43.3 - Sep 21
Comment 3•9 years ago
|
||
Regression, tracking it.
Matthew, any reason why this didn't land yet?
Flags: needinfo?(MattN+bmo)
Assignee | ||
Comment 4•9 years ago
|
||
Comment on attachment 8654365 [details]
MozReview Request: Bug 1199805 - Fix displayURI typo on site permission prompts. r=bgrins
Bug 1199805 - Fix displayURI typo on site permission prompts. r=bgrins
One instance of displayOrigin wasn't renamed to displayURI.
Assignee | ||
Comment 5•9 years ago
|
||
(In reply to Sylvestre Ledru [:sylvestre] from comment #3)
> Matthew, any reason why this didn't land yet?
Missing a test as explained in comment 0 and comment 2.
Flags: needinfo?(MattN+bmo)
Comment 7•9 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
status-firefox43:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 43
Assignee | ||
Comment 8•9 years ago
|
||
Comment on attachment 8654365 [details]
MozReview Request: Bug 1199805 - Fix displayURI typo on site permission prompts. r=bgrins
Approval Request Comment
[Feature/regressing bug #]: Bug 1175300 regression via typo
[User impact if declined]: Users won't know which site is asking them for permission which can be a spoofing/security/privacy issue
[Describe test coverage new/current, TreeHerder]: New test to ensure at least the base domain is present in the notification.
[Risks and why]: Extremely low risk typo fix
[String/UUID change made/needed]: None
Attachment #8654365 -
Flags: approval-mozilla-aurora?
Comment 9•9 years ago
|
||
Comment on attachment 8654365 [details]
MozReview Request: Bug 1199805 - Fix displayURI typo on site permission prompts. r=bgrins
Make sense, taking it into 42.
Attachment #8654365 -
Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Comment 10•9 years ago
|
||
You need to log in
before you can comment on or make changes to this bug.
Description
•