Closed
Bug 1200099
Opened 9 years ago
Closed 9 years ago
Eliminate HTMLMediaElement::mPlaybackStream
Categories
(Core :: Audio/Video, defect)
Core
Audio/Video
Tracking
()
RESOLVED
FIXED
mozilla43
Tracking | Status | |
---|---|---|
firefox43 | --- | fixed |
People
(Reporter: roc, Assigned: roc)
References
Details
(Whiteboard: [backout-asap])
Attachments
(4 files, 5 obsolete files)
(deleted),
text/x-review-board-request
|
jwwang
:
review+
|
Details |
(deleted),
text/x-review-board-request
|
jwwang
:
review+
|
Details |
MozReview Request: Bug 1200099. Relax test assumptions to accommodate streams not blocking. r=jwwang
(deleted),
text/x-review-board-request
|
jwwang
:
review+
|
Details |
(deleted),
text/x-review-board-request
|
jwwang
:
review+
|
Details |
We don't really need this. Instead of blocking MediaStream playback when the media element is paused, we can just disconnect the MediaStream output, and then reconnect it if we play again.
This simplifies code and makes progress towards fixing bug 1189506.
Assignee | ||
Comment 1•9 years ago
|
||
Assignee | ||
Comment 2•9 years ago
|
||
Assignee | ||
Comment 3•9 years ago
|
||
Assignee | ||
Comment 4•9 years ago
|
||
Green except where I'm hitting bug 1084185. I'll work around that by making test_streams_element_capture behave like test_streams_element_capture_reset.
Assignee | ||
Comment 5•9 years ago
|
||
Green on Linux64 that is...
Assignee | ||
Comment 6•9 years ago
|
||
Assignee | ||
Comment 7•9 years ago
|
||
Assignee | ||
Comment 8•9 years ago
|
||
Bug 1200099. Ensure mSameOriginMedia is propagated to DecodedStream even if we don't get a watch notification. r=jwwang
Attachment #8655718 -
Flags: review?(jwwang)
Assignee | ||
Comment 9•9 years ago
|
||
Bug 1200099. Add a test that captured cross-origin video streams render black. r=jwwang
Attachment #8655719 -
Flags: review?(jwwang)
Assignee | ||
Comment 10•9 years ago
|
||
Bug 1200099. Ensure mSameOrigin is initialized. r=jwwang
Attachment #8655720 -
Flags: review?(jwwang)
Assignee | ||
Comment 11•9 years ago
|
||
Bug 1200099. Relax test assumptions to accommodate streams not blocking. r=jwwang
Attachment #8655721 -
Flags: review?(jwwang)
Assignee | ||
Comment 12•9 years ago
|
||
Bug 1200099. Stop using a distinct mPlaybackStream to play a media stream through an HTMLMediaElement. r=jwwang
Attachment #8655722 -
Flags: review?(jwwang)
Assignee | ||
Updated•9 years ago
|
Attachment #8655718 -
Attachment is obsolete: true
Attachment #8655718 -
Flags: review?(jwwang)
Assignee | ||
Updated•9 years ago
|
Attachment #8655719 -
Attachment is obsolete: true
Attachment #8655719 -
Flags: review?(jwwang)
Assignee | ||
Updated•9 years ago
|
Attachment #8655720 -
Attachment is obsolete: true
Attachment #8655720 -
Flags: review?(jwwang)
Assignee | ||
Updated•9 years ago
|
Attachment #8655721 -
Attachment is obsolete: true
Attachment #8655721 -
Flags: review?(jwwang)
Assignee | ||
Updated•9 years ago
|
Attachment #8655722 -
Attachment is obsolete: true
Attachment #8655722 -
Flags: review?(jwwang)
Assignee | ||
Comment 13•9 years ago
|
||
Bug 1200099. Ensure mSameOriginMedia is propagated to DecodedStream even if we don't get a watch notification. r=jwwang
Attachment #8655728 -
Flags: review?(jwwang)
Assignee | ||
Comment 14•9 years ago
|
||
Bug 1200099. Add a test that captured cross-origin video streams render black. r=jwwang
Attachment #8655729 -
Flags: review?(jwwang)
Assignee | ||
Comment 15•9 years ago
|
||
Bug 1200099. Relax test assumptions to accommodate streams not blocking. r=jwwang
Attachment #8655730 -
Flags: review?(jwwang)
Assignee | ||
Comment 16•9 years ago
|
||
Bug 1200099. Stop using a distinct mPlaybackStream to play a media stream through an HTMLMediaElement. r=jwwang
Attachment #8655731 -
Flags: review?(jwwang)
Comment 17•9 years ago
|
||
Comment on attachment 8655728 [details]
MozReview Request: Bug 1200099. Ensure mSameOriginMedia is propagated to DecodedStream even if we don't get a watch notification. r=jwwang
https://reviewboard.mozilla.org/r/18007/#review16127
::: dom/media/MediaDecoderStateMachine.cpp:336
(Diff revision 1)
> + SameOriginMediaChanged();
I believe this is fixed by bug 1199654 which give DecodedStream::mSameOrigin an initial false value.
Attachment #8655728 -
Flags: review?(jwwang) → review+
Comment 18•9 years ago
|
||
Comment on attachment 8655729 [details]
MozReview Request: Bug 1200099. Add a test that captured cross-origin video streams render black. r=jwwang
https://reviewboard.mozilla.org/r/18009/#review16131
Attachment #8655729 -
Flags: review?(jwwang) → review+
Updated•9 years ago
|
Attachment #8655730 -
Flags: review?(jwwang) → review+
Comment 19•9 years ago
|
||
Comment on attachment 8655730 [details]
MozReview Request: Bug 1200099. Relax test assumptions to accommodate streams not blocking. r=jwwang
https://reviewboard.mozilla.org/r/18011/#review16129
::: dom/media/test/test_streams_element_capture.html:78
(Diff revision 1)
> -manager.runTests(gSmallTests, startTest);
> +var testVideo = getPlayableVideo(gSmallTests);
Might be worth a todo that we test only one file for the duration bug of gstreamer. Once it is fixed, we are able to run through all files in gSmallTests again.
Comment 20•9 years ago
|
||
Comment on attachment 8655731 [details]
MozReview Request: Bug 1200099. Stop using a distinct mPlaybackStream to play a media stream through an HTMLMediaElement. r=jwwang
https://reviewboard.mozilla.org/r/18013/#review16133
::: dom/media/VideoFrameContainer.cpp
(Diff revision 1)
> - mImageSizeChanged = false;
Why deleting this line?
Attachment #8655731 -
Flags: review?(jwwang) → review+
Assignee | ||
Comment 21•9 years ago
|
||
https://reviewboard.mozilla.org/r/18007/#review16127
> I believe this is fixed by bug 1199654 which give DecodedStream::mSameOrigin an initial false value.
That's probably true, but I think it's best to avoid assuming that mDecoder's mSameOriginMedia is false when InitializationTask runs.
Assignee | ||
Comment 22•9 years ago
|
||
https://reviewboard.mozilla.org/r/18013/#review16165
::: dom/media/VideoFrameContainer.cpp
(Diff revision 1)
> - mImageSizeChanged = false;
If the video frame changes size, and then someone calls ClearCurrentFrame, we should still ensure that InvalidateFrame gets called by VideoFrameContainer::InvalidateWithFlags. It's simpler and safer to only clear mImageSizeChanged when we actually call InvalidateFrame, anyway.
Comment 23•9 years ago
|
||
Comment 24•9 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/526a487b5ac8
https://hg.mozilla.org/mozilla-central/rev/af77d3d2496d
https://hg.mozilla.org/mozilla-central/rev/84cc83e991e0
https://hg.mozilla.org/mozilla-central/rev/e110acdf8e64
Status: NEW → RESOLVED
Closed: 9 years ago
Flags: in-testsuite+
Resolution: --- → FIXED
Target Milestone: --- → mozilla43
You need to log in
before you can comment on or make changes to this bug.
Description
•