Closed
Bug 1200252
Opened 9 years ago
Closed 9 years ago
Add marker for when the IPC request for a composite is sent to the compositor thread
Categories
(DevTools :: Performance Tools (Profiler/Timeline), defect)
DevTools
Performance Tools (Profiler/Timeline)
Tracking
(firefox43 fixed)
RESOLVED
FIXED
Firefox 43
| Tracking | Status | |
|---|---|---|
| firefox43 | --- | fixed |
People
(Reporter: vporof, Assigned: vporof)
References
Details
Attachments
(1 file)
|
(deleted),
patch
|
jsantell
:
review+
mattwoodrow
:
review+
|
Details | Diff | Splinter Review |
No description provided.
|
Assignee | |
Updated•9 years ago
|
Blocks: perf-gaming
No longer depends on: perf-gaming
|
|
Assignee | |
Comment 1•9 years ago
|
||
Assignee: nobody → vporof
Status: NEW → ASSIGNED
Attachment #8659242 -
Flags: review?(matt.woodrow)
Attachment #8659242 -
Flags: review?(jsantell)
|
||
Updated•9 years ago
|
Attachment #8659242 -
Flags: review?(matt.woodrow) → review+
|
||
Comment 2•9 years ago
|
||
Comment on attachment 8659242 [details] [diff] [review]
v1
Review of attachment 8659242 [details] [diff] [review]:
-----------------------------------------------------------------
r+ for js/css changes
::: browser/devtools/performance/modules/markers.js
@@ +79,5 @@
> label: L10N.getStr("marker.label.composite"),
> },
> + "CompositeForwardTransaction": {
> + group: 0,
> + colorName: "graphs-bluegrey",
Should also be green, no? I guess ultimately these will be rolled into their own "frame" marker though
Attachment #8659242 -
Flags: review?(jsantell) → review+
|
|
Assignee | |
Comment 3•9 years ago
|
||
(In reply to Jordan Santell [:jsantell] [@jsantell] from comment #2)
> Comment on attachment 8659242 [details] [diff] [review]
> v1
>
> Review of attachment 8659242 [details] [diff] [review]:
> -----------------------------------------------------------------
>
> r+ for js/css changes
>
> ::: browser/devtools/performance/modules/markers.js
> @@ +79,5 @@
> > label: L10N.getStr("marker.label.composite"),
> > },
> > + "CompositeForwardTransaction": {
> > + group: 0,
> > + colorName: "graphs-bluegrey",
>
> Should also be green, no? I guess ultimately these will be rolled into their
> own "frame" marker though
Don't think so. That's why I added bluegrey – this operation isn't a composite per se, it's a composite request. Different.
|
||
Comment 5•9 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
status-firefox43:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 43
|
||
Updated•6 years ago
|
Product: Firefox → DevTools
You need to log in
before you can comment on or make changes to this bug.
Description
•