Unify pseudo class colors in markup view and rule view
Categories
(DevTools :: Inspector, defect, P3)
Tracking
(firefox43 affected)
| Tracking | Status | |
|---|---|---|
| firefox43 | --- | affected |
People
(Reporter: bgrins, Assigned: akshithashetty84)
References
Details
(Whiteboard: [btpp-backlog])
Attachments
(2 files)
The final outcome after making the discussed changes are as above
|
||
Updated•9 years ago
|
|
||
Comment 1•9 years ago
|
||
|
||
Updated•6 years ago
|
|
||
Comment 2•6 years ago
|
||
We want to change the pseudo-class colors to specific shades of Photon Yellow as described here:
https://github.com/firefox-devtools/ux/issues/13#issuecomment-467643399
So I'm thinking we should hijack this bug which is very close. :)
Here's my shot at a spec:
Colors:
- Dark theme: pseudo-class colors should be Yellow 50 for text & Yellow 60 for the markup indicator (disc)
- Light theme: pseudo-class colors should be Yellow 70 for text & Yellow 60 for the markup indicator (disc)
Locations where this should be applied:
- Disc indicators in markup view (probably
devtools/client/themes/markup.css) - Pseudo-class selector text in Rules (probably
devtools/client/themes/rules.css) - Pseudo-class text in the breadcrumbs (probably
devtools/client/themes/breadcrumbs.css). Note: the currently "active" element (element which is focused in the markup view) uses blue text; that shouldn't change.
Gabriel, do you know if there are more places to look at?
|
Assignee | |
Comment 3•6 years ago
|
||
Hi, as discussed in https://github.com/firefox-devtools/ux/issues/13#issuecomment-462405738, I would like to take up this one. Could you please assign it to me?
Thanks.
|
|
Assignee | |
Comment 4•6 years ago
|
||
|
||
Comment 5•6 years ago
|
||
(In reply to Florens Verschelde :fvsch from comment #2)
We want to change the pseudo-class colors to specific shades of Photon Yellow as described here:
https://github.com/firefox-devtools/ux/issues/13#issuecomment-467643399
So I'm thinking we should hijack this bug which is very close. :)Here's my shot at a spec:
Colors:
- Dark theme: pseudo-class colors should be Yellow 50 for text & Yellow 60 for the markup indicator (disc)
- Light theme: pseudo-class colors should be Yellow 70 for text & Yellow 60 for the markup indicator (disc)
Locations where this should be applied:
- Disc indicators in markup view (probably
devtools/client/themes/markup.css)- Pseudo-class selector text in Rules (probably
devtools/client/themes/rules.css)- Pseudo-class text in the breadcrumbs (probably
devtools/client/themes/breadcrumbs.css). Note: the currently "active" element (element which is focused in the markup view) uses blue text; that shouldn't change.Gabriel, do you know if there are more places to look at?
List looks fine to me.
|
|
||
Updated•6 years ago
|
|
|
Assignee | |
Comment 6•6 years ago
|
||
Bug 1200686 - Unify pseudo class clors in markup view and rule view. r=fvsch
|
||
Updated•6 years ago
|
|
|
Assignee | |
Comment 8•6 years ago
|
||
Thank you.
|
||
Comment 9•6 years ago
|
||
| bugherder | ||
|
|
Assignee | |
Comment 10•6 years ago
|
||
Hi, this issue has been fixed I suppose. Could you please guide me on updating the status of this one ?
|
|
||
Updated•6 years ago
|
Description
•