During the 2.35 release, I thought I had the source step done (green). But what I didn't know was that it wasn't done despite it being green. The actual tarball wasn't uploaded. This requires a change in the suite/build.mk. 'source-upload' rule needs to be added. Specifically something like: http://hg.mozilla.org/releases/comm-esr38/file/3016795500a2/mail/build.mk#l31 This must be done in the next c-b AND c-r. this is a blocker for the next beta/release.

Comment on attachment 8655899 [details] [diff] [review] proposed patch (v1) With regards to this change, it will make us look consistent with mail/ et. al; however, all |make source-upload| does is to run, as mentioned in the patch, |make -C suite/installer source-upload| which in turn calls |make upload UPLOAD_FILES='$(SOURCE_UPLOAD_FILES)' CHECKSUM_FILE='$(SOURCE_CHECKSUM_FILE)'| I'm 'guessing' both SOURCE_UPLOAD_FILES and SOURCE_CHECKSUM_FILE are generated during make upload via the |make upload| command?

Comment on attachment 8655899 [details] [diff] [review] proposed patch (v1) Review of attachment 8655899 [details] [diff] [review]: ----------------------------------------------------------------- rs=me

(In reply to Edmund Wong (:ewong) from comment #2) > I'm 'guessing' both SOURCE_UPLOAD_FILES and SOURCE_CHECKSUM_FILE are > generated during make upload via the |make upload| command? You'll probably get better answers asking glandium here.

(In reply to Joshua Cranmer [:jcranmer] from comment #4) > (In reply to Edmund Wong (:ewong) from comment #2) > > I'm 'guessing' both SOURCE_UPLOAD_FILES and SOURCE_CHECKSUM_FILE are > > generated during make upload via the |make upload| command? > > You'll probably get better answers asking glandium here. Thanks.. will n-i him. :glandium, is comment #2 right?

According to https://dxr.mozilla.org/mozilla-central/source/toolkit/mozapps/installer/upload-files.mk?offset=0#807-808 yes.

Comment on attachment 8655899 [details] [diff] [review] proposed patch (v1) [Triage Comment] This is needed for the source step's make upload. Without it, the source step fails.

Comment on attachment 8655899 [details] [diff] [review] proposed patch (v1) Pushed to comm-central: https://hg.mozilla.org/comm-central/rev/9f515d59d5f5 Pushed to comm-aurora: https://hg.mozilla.org/releases/comm-aurora/rev/e056e4c10b2c Pushed to comm-beta: https://hg.mozilla.org/releases/comm-beta/rev/43b243847ecc Pushed to comm-release: https://hg.mozilla.org/releases/comm-release/rev/0277ad235ac9