Closed
Bug 120107
Opened 23 years ago
Closed 23 years ago
[FLOAT]Inset graphic on right renders incorrectly [FIXED_ON_TRUNK]
Categories
(Core :: Layout, defect, P3)
Core
Layout
Tracking
()
VERIFIED
FIXED
mozilla1.0.1
People
(Reporter: jasonp019, Assigned: karnaze)
References
()
Details
(Keywords: css1, testcase, topembed+, Whiteboard: [adt2] [CSS1-5.5.25])
Attachments
(4 files, 4 obsolete files)
(deleted),
image/jpeg
|
Details | |
(deleted),
text/html
|
Details | |
(deleted),
text/plain
|
Details | |
(deleted),
patch
|
bernd_mozilla
:
review+
waterson
:
superreview+
|
Details | Diff | Splinter Review |
From Bugzilla Helper:
User-Agent: Mozilla/5.0 Galeon/1.1 (X11; Linux i686; U;) Gecko/20011226
BuildID: 2001122617
The inset graphic on the right side of the screen renders incorrectly. The
graphic partially obscurs and interferes with the rendering of the right-hand
sidebar.
Reproducible: Always
Steps to Reproduce:
1.Visit the URL
Actual Results: Same as in the description above
Expected Results: I'm not sure as I can't access another modern browser at this
time.
Comment 1•23 years ago
|
||
Confirmed. This appeared when I first loaded the page and reloaded, but both
going back and then to the page again, and viewing in DOM Inspector, resulted in
correct rendering.
Status: UNCONFIRMED → NEW
Ever confirmed: true
Reporter | ||
Comment 2•23 years ago
|
||
Hmmm...how do you do what you described? I popped open the DOM inspector and
worked my way down the tree to that IMG tag and it still was mis-rendered.
Then, I went to another page and back to it and it still mis-rendered. :)
Thanks!
--Jason
Comment 3•23 years ago
|
||
Looks like a floater issue. Reassigning to Alex.
Assignee: attinasi → alexsavulov
Target Milestone: --- → mozilla1.0
Comment 4•23 years ago
|
||
is displayed correctly if you hit corectly if back/fwd or fwd/back with
2002013103(w32) and 2002011408(linux).
I will attach a testcase
Comment 5•23 years ago
|
||
Comment 6•23 years ago
|
||
i tested the URL with 2002013103(win32) and 2002011408(linux) and if you hit
back/fwd or fwd/back the page displays correctly
Reporter | ||
Comment 7•23 years ago
|
||
Yes, it does with my mozilla now. Any idea why it doesn't rener properly initially?
Thanks!
--Jason
Comment 8•23 years ago
|
||
*** Bug 124962 has been marked as a duplicate of this bug. ***
Comment 9•23 years ago
|
||
Moving to Mozilla1.1. Engineers are overloaded with higher priority bugs.
Target Milestone: mozilla1.0 → mozilla1.1
Updated•23 years ago
|
Comment 10•23 years ago
|
||
*** Bug 141733 has been marked as a duplicate of this bug. ***
Comment 11•23 years ago
|
||
duplicate of bug 97057?
Comment 12•23 years ago
|
||
Removed a few unnecessary elements.
Attachment #67313 -
Attachment is obsolete: true
Comment 13•23 years ago
|
||
This trace is the incremental reflow of the image frame, which makes me think
this is _not_ a floater bug, but a table incremental reflow bug. Notice that
the table cell's width is correctly increased, but the row and the rowgroup do
not expand horizontally.
Comment 14•23 years ago
|
||
-> tables.
Assignee: alexsavulov → karnaze
Component: Layout → HTMLTables
QA Contact: petersen → amar
Summary: [FLOAT]Inset graphic on right renders incorrectly → Inset graphic on right renders incorrectly
Comment 15•23 years ago
|
||
Hmmkay. My bad: I dug a little deeper and it looks like we're not updating the
MES when we incrementally reflow that floater. Taking back...
Assignee: karnaze → waterson
Component: HTMLTables → Layout
Summary: Inset graphic on right renders incorrectly → [FLOAT]Inset graphic on right renders incorrectly
Comment 16•23 years ago
|
||
Okay, here's what's happening AFAICT.
1. The inline frame is being asked to compute its MES by the outer table. So,
it does an unconstrained reflow of its lines.
2. The floated table frame is flowed by its placeholder frame at an
unconstrained width. It correctly detects that it's going to need to do a
second-pass reflow when the incremental reflow is processed by the cell.
3. However, on the way _out_ of the reflow, it never bothers doing the second-
pass reflow, assuming that since it's gotten an unconstrained reflow, it'll
get flowed again. (See nsTableFrame.cpp:2141.)
4. Therefore, the floated element is returned the original table cell's width,
which it assumes is the MES, and stores it away.
5. We return back out to the inline frame, which now reflows the line again,
but this time _without_ requesting that its children compute MES.
6. We return the narrower MES out to the enclosing table, and things look
wrong.
So, it seems to me that the table frame shouldn't be deferring that second-pass
reflow in (3), above. Or, we should be requesting that children compute the MES
*again* during the second-pass line reflow in (5).
Status: NEW → ASSIGNED
OS: Linux → All
Priority: -- → P3
Hardware: PC → All
Comment 17•23 years ago
|
||
So, one way to do this is to allow the second-pass reflow to happen when the
table detects that it needs rebalancing, and _either_ it's not an unconstrained
reflow, or the MES is being requested.
Assignee | ||
Comment 18•23 years ago
|
||
This patch does not fix bug 141021 (but I'll be attaching another patch to that
bug shortly).
Attachment #82155 -
Attachment is obsolete: true
Assignee | ||
Comment 19•23 years ago
|
||
Attachment #82601 -
Attachment is obsolete: true
Comment 20•23 years ago
|
||
karnaze, it looks like you've got this covered. ;-)
Assignee: waterson → karnaze
Status: ASSIGNED → NEW
Assignee | ||
Comment 21•23 years ago
|
||
Attachment #82629 -
Attachment is obsolete: true
Comment 22•23 years ago
|
||
Comment on attachment 82656 [details] [diff] [review]
revised patch (a little more efficient)
r=bernd
Attachment #82656 -
Flags: review+
Comment 23•23 years ago
|
||
Comment on attachment 82656 [details] [diff] [review]
revised patch (a little more efficient)
sr=waterson
Attachment #82656 -
Flags: superreview+
Assignee | ||
Comment 24•23 years ago
|
||
FIXED_ON_TRUNK
Status: NEW → RESOLVED
Closed: 23 years ago
Resolution: --- → FIXED
Summary: [FLOAT]Inset graphic on right renders incorrectly → [FLOAT]Inset graphic on right renders incorrectly [FIXED_ON_TRUNK]
Comment 25•23 years ago
|
||
*** Bug 142090 has been marked as a duplicate of this bug. ***
Comment 26•22 years ago
|
||
According to Bernd, this patch might have fixed
http://www.nexgenmedia.net/evang/ftd.de/, which is a simplified testcase of a
german topsite/AOL Partner (bugscape 16499). If so, this should go into the
branch for MachV.
Comment 27•22 years ago
|
||
*** Bug 150838 has been marked as a duplicate of this bug. ***
Comment 28•22 years ago
|
||
amar: can you pls verify this as fixed, and check around for any possible
regressions. thanks!
Blocks: 143047
Whiteboard: [CSS1-5.5.25] → [adt2 RTM] [CSS1-5.5.25] [ETA 08/08]
Comment 29•22 years ago
|
||
Jaime: This bug is fixed on the trunk. Its not checked into branch. This bug
still exists on branch build: 2002-08-05-12-1.0.
Verified fixed on trunk build: 2002-08-05-08-trunk.
No regressions found on trunk.
Comment 30•22 years ago
|
||
Marking as Verified for the trunk per Comment #29 From Amarendra Hanumanula.
Status: RESOLVED → VERIFIED
Keywords: topembed
Whiteboard: [adt2 RTM] [CSS1-5.5.25] [ETA 08/08] → [adt2] [CSS1-5.5.25]
Comment 32•22 years ago
|
||
mozilla1.0.1 has passed. carrying over nomination to mozilla1.0.2 (and adding
topembed+), as this fixes a topsite in germany.
Comment 33•22 years ago
|
||
This bug does not meet the Blackbird criteria, adt-
You need to log in
before you can comment on or make changes to this bug.
Description
•