Closed
Bug 1201214
Opened 9 years ago
Closed 4 years ago
Handle return values of FallibleTArray functions in dom/svg/
Categories
(Core :: SVG, defect)
Core
SVG
Tracking
()
RESOLVED
FIXED
mozilla80
People
(Reporter: mccr8, Assigned: longsonr)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
(deleted),
text/x-phabricator-request
|
Details |
There are a few of these in dom/svg. Ideally, we'd check the return value. What should be done for these?
3 AppendElement calls in SVGMotionSMILAnimationFunction::RebuildPathAndVerticesFromBasicAttrs:
SVGMotionSMILAnimationFunction.cpp:177
SVGMotionSMILAnimationFunction.cpp:185
SVGMotionSMILAnimationFunction.cpp:203
1 AppendElement call in SVGTransformListSMILType::GetTransforms:
SVGTransformListSMILType.cpp:366
Reporter | ||
Comment 1•9 years ago
|
||
jwatt, maybe you have some idea what should be done for these calls? Thanks.
Flags: needinfo?(jwatt)
Reporter | ||
Comment 2•9 years ago
|
||
I guess there's no particular hurry on this. There are probably a huge number of AppendElement calls that don't check their return value.
Flags: needinfo?(jwatt)
Reporter | ||
Updated•9 years ago
|
Assignee | ||
Comment 3•4 years ago
|
||
Fortunately bug 1631371 has marked the methods and SVGPathData::GetSegmentLengths is dead code
Updated•4 years ago
|
Assignee: nobody → longsonr
Status: NEW → ASSIGNED
Pushed by longsonr@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/83984c20e08c
Deal with AppendElement failing if it's called in a fallible way r=jwatt
Comment 5•4 years ago
|
||
bugherder |
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
status-firefox80:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla80
Updated•4 years ago
|
You need to log in
before you can comment on or make changes to this bug.
Description
•