Now including the deleted template.

Comment on attachment 8656241 [details] [diff] [review] patch, v1.1 I have two comments: * We are using a date picker for a date/time field. Is there no date/time picker in default jQuery? Should we be adding one? It seems confusing to get someone to use a date picker to pick a value for a date/time field, because they may assume it's only a date field. If we are going to do this, can we get it to insert an " 00:00" when you pick a value, to give people a visual clue? * I think weeks should display starting on a Monday. Having the two weekend days grouped together makes more sense. Gerv

Comment on attachment 8656241 [details] [diff] [review] patch, v1.1 (In reply to Gervase Markham [:gerv] from comment #2) > * We are using a date picker for a date/time field. This is exactly what we do currently with YUI, so this is not a regression. And no, there is no time picker in the default jQuery. So for users, there are no functional changes. > * I think weeks should display starting on a Monday. Having the two weekend > days grouped together makes more sense. That's pretty common practice in Europe, and I also much prefer starting weeks on Monday too. But in the USA, the first day of the week is Sunday, as documented here: http://www.timeanddate.com/calendar/days/ "The first day of the week varies all over the world. In most cultures, Sunday is regarded as the first day of the week although many observe Monday as the first day of the week. [...] countries such as the United States still have their calendars refer to Sunday as the start of the seven-day week." So I kept Sunday as the first day of the week, as we do currently with YUI. So this is not a regression. But that's why I added the |firstDay: 0| argument to let admins easily change this value based on their location. For instance, I know french and german templates will set firstDay to 1, but a US-based installation will keep it set to 0. Based on the comments above, could you please reconsider your review?

(In reply to Frédéric Buclin from comment #3) > "The first day of the week varies all over the world. In most cultures, > Sunday is regarded as the first day of the week although many observe Monday > as the first day of the week. [...] countries such as the United States > still have their calendars refer to Sunday as the start of the seven-day > week." You missed out: "According to the international standard ISO 8601, Monday is the first day of the week ending with Sunday as the seventh day of the week." :-) > So I kept Sunday as the first day of the week, as we do currently with YUI. > So this is not a regression. I agree it's not a regression. Gerv

(In reply to Gervase Markham [:gerv] from comment #4) > You missed out: "According to the international standard ISO 8601, Monday is > the first day of the week I didn't miss it. But this is counter-balanced by "In most cultures, Sunday is regarded as the first day of the week". :) Should we make most people happy by default, or the RFC happy? ;) Ideally, both should match (and use Monday as the first day of the week, of course ;)), this would make our decision easier.

To ssh://gitolite3@git.mozilla.org/bugzilla/bugzilla.git b3abb29..b92f32d master -> master