Closed
Bug 1201668
Opened 9 years ago
Closed 9 years ago
Allow running Firefox UI update tests through a python wrapper script
Categories
(Testing :: Firefox UI Tests, defect)
Tracking
(firefox40 fixed, firefox41 fixed, firefox42 fixed, firefox43 fixed, firefox-esr38 fixed)
RESOLVED
FIXED
mozilla43
People
(Reporter: armenzg, Assigned: armenzg)
References
Details
Attachments
(1 file, 1 obsolete file)
When setting up the Firefox UI tests repository, it generates two binaries, one of them called firefox-ui-update. Calling this binary on Windows triggers the UAC prompt for the Release Engineering Windows test machines.
If instead we use Python to call a script that calls the same functionality we don't get this UAC prompt.
|
Assignee | |
Updated•9 years ago
|
Summary: Add two scripts to run the Firefox UI tests → Allow running Firefox UI update tests through a python wrapper script
|
|
Assignee | |
Comment 1•9 years ago
|
||
Attachment #8656807 -
Flags: review?(hskupin)
|
||
Comment 2•9 years ago
|
||
Comment on attachment 8656807 [details]
Allow running Firefox UI update tests through a python wrapper script
It looks fine but I think we better do more. See my comments on the PR.
Attachment #8656807 -
Flags: review?(hskupin) → review-
|
|
Assignee | |
Comment 3•9 years ago
|
||
Addressed comments.
Attachment #8656807 -
Attachment is obsolete: true
Attachment #8658233 -
Flags: review?(hskupin)
|
|
Assignee | |
Updated•9 years ago
|
Status: NEW → ASSIGNED
|
|
||
Comment 4•9 years ago
|
||
Comment on attachment 8658233 [details]
Allow running Firefox UI update tests through a python wrapper script
Looks great. Just address the small nit, and get it landed as a single commit with the proper commit message. Thanks.
Attachment #8658233 -
Flags: review?(hskupin) → review+
|
|
Assignee | |
Comment 5•9 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
|
|
||
Comment 6•9 years ago
|
||
It's not enough to only merge this PR to master. We also need it backported across all branches. Sadly it landed without being squashed so we have to carry all those extra commits with us.
Once our tests have been run today I'm going to do the backport.
Status: RESOLVED → REOPENED
status-firefox40:
--- → affected
status-firefox41:
--- → affected
status-firefox42:
--- → affected
status-firefox43:
--- → fixed
status-firefox-esr38:
--- → affected
Resolution: FIXED → ---
Target Milestone: --- → Firefox 43
|
|
||
Comment 7•9 years ago
|
||
So I had issues cherry-picking those commits for the other branches. After searching for a bit I was able to find some documentation in actually how to cherry-pick merge commits:
https://salilp.wordpress.com/2015/08/04/cherry-picking-a-git-merge-commit-from-a-branch/
So this patch got cherry-picked for the other branches:
https://github.com/mozilla/firefox-ui-tests/commit/973aaa59156d45894ed6c4cde3684b746f6c3d62 (aurora)
https://github.com/mozilla/firefox-ui-tests/commit/a217ed1a50c0f5b6c3ecdd5ddd43017b5f83d5b6 (beta)
https://github.com/mozilla/firefox-ui-tests/commit/90a922f94522abefff28480f24d4574526a24930 (release)
https://github.com/mozilla/firefox-ui-tests/commit/d099e77121b3d4de09d2aceb8450bf59b27eda09 (esr38)
Status: REOPENED → RESOLVED
Closed: 9 years ago → 9 years ago
Resolution: --- → FIXED
|
||
Updated•9 years ago
|
Product: Mozilla QA → Testing
You need to log in
before you can comment on or make changes to this bug.
Description
•