Closed Bug 1201703 Opened 9 years ago Closed 9 years ago

[Control Center] Icons overlap text and are on the wrong side for the RTL locales

Categories

(Firefox :: General, defect, P1)

Product:
Firefox
Component:
General
Type:
defect

Tracking

()

Status:
VERIFIED FIXED
Milestone:
Firefox 44
Iteration:
44.2 - Oct 19
Tracking Flags:
Tracking Status
firefox42 + verified
firefox43 --- verified
firefox44 --- verified

People

(Reporter: dr.khaled.hosny, Assigned: past)

References

Details

(Whiteboard: [fxprivacy])

Attachments

(1 file)

Patch v1
(deleted), patch
Paolo
: review+
Sylvestre
: approval-mozilla-aurora+
Sylvestre
: approval-mozilla-beta+
Details | Diff | Splinter Review
Javaun, which component is control center?
Status: UNCONFIRMED → NEW
Ever confirmed: true
Flags: needinfo?(jmoradi)
Pike I'm not sure I'm answering correctly. The Control Center is the door hanger that drops from the url bar icon and houses the restyled security and identity information and in Private Browsing also contains tracking protection controls
Flags: needinfo?(jmoradi)
(In reply to Javaun Moradi [:javaun] from comment #2) > Pike I'm not sure I'm answering correctly. The Control Center is the door > hanger that drops from the url bar icon and houses the restyled security and > identity information and in Private Browsing also contains tracking > protection controls I think the question was: which component of Bugzilla covers Control Center? I see several bugs filed in Firefox::General (e.g. bug 1170759), so I'll move it there. It would be helpful to know if there's a bug that this one could block.
Component: Untriaged → General
Summary: Icons overlap text and are on the wrong side for the RTL locales → [Control Center] Icons overlap text and are on the wrong side for the RTL locales
[Tracking Requested - why for this release]: This is a UI problem in RTL locales in a prominent 42 release.
status-firefox42: --- → affected
tracking-firefox42: --- → ?
Visual issue, tracking.
tracking-firefox42: ? → +
Whiteboard: [fxprivacy][triage]
Priority: -- → P1
Whiteboard: [fxprivacy][triage] → [fxprivacy]
Blocks: 1188565
Assignee: nobody → past
Status: NEW → ASSIGNED
Panos, you can look at the patch in bug 1200661 for a fix to a similar issue: https://reviewboard.mozilla.org/r/18205/diff/1#0 Maybe you need -moz-locale-dir rather than -moz-dir for chrome code, not sure about that.
Iteration: --- → 44.1 - Oct 5
Flags: qe-verify?
Thanks Paolo, will do.
Flags: qe-verify? → qe-verify+
Iteration: 44.1 - Oct 5 → 44.2 - Oct 19
Hi Florin, can a QA contact be assigned.
Flags: needinfo?(florin.mezei)
Flags: needinfo?(florin.mezei)
QA Contact: petruta.rasa
Attached patch Patch v1 (deleted) — — Splinter Review
Your comment 6 was spot on!
Attachment #8671604 - Flags: review?(paolo.mozmail)
Comment on attachment 8671604 [details] [diff] [review] Patch v1 Review of attachment 8671604 [details] [diff] [review]: ----------------------------------------------------------------- Thanks for looking into this!
Attachment #8671604 - Flags: review?(paolo.mozmail) → review+
https://hg.mozilla.org/mozilla-central/rev/20bb8fec6bad
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
status-firefox44: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 44
Comment on attachment 8671604 [details] [diff] [review] Patch v1 Approval Request Comment [Feature/regressing bug #]: not sure, but it might have been the Control Center work [User impact if declined]: users in RTL locales will have display issues in the control center [Describe test coverage new/current, TreeHerder]: manual testing [Risks and why]: tiny risk, CSS-only change limited to RTL locales [String/UUID change made/needed]: none
Attachment #8671604 - Flags: approval-mozilla-beta?
Attachment #8671604 - Flags: approval-mozilla-aurora?
Comment on attachment 8671604 [details] [diff] [review] Patch v1 Improve the RTL support, taking it. Should be in 42 beta 6.
Attachment #8671604 - Flags: approval-mozilla-beta?
Attachment #8671604 - Flags: approval-mozilla-beta+
Attachment #8671604 - Flags: approval-mozilla-aurora?
Attachment #8671604 - Flags: approval-mozilla-aurora+
Verified fixed FF 42b6, 43.0a2 (2015-10-13), 44.0a1 (2015-10-12) AR on Win 7, OS X 10.10.
Status: RESOLVED → VERIFIED
status-firefox42: fixed → verified
status-firefox43: fixed → verified
status-firefox44: fixed → verified
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: