Closed
Bug 1201865
Opened 9 years ago
Closed 9 years ago
Notifications don't appear
Categories
(support.mozilla.org :: BuddyUp, defect, P2)
support.mozilla.org
BuddyUp
Tracking
(tracking-b2g:+, b2g-master affected)
Tracking | Status | |
---|---|---|
b2g-master | --- | affected |
People
(Reporter: fredy, Assigned: rehandalal+mozilla)
References
Details
(Whiteboard: u=user p=1 blocking-b2g)
Steps to reproduce:
1. With device 1 ask a question
2. Press back button when the question is sent
3. With device 2 answer the question
Expected result:
Device 1 should get a notification
Actual result:
Device one doesn't get any notification
I've done a little debugging and I've seen that the api for notifications works fine and returns a response with notifications details. However something gets wrong and the app doesn't create the notifications.
Reporter | ||
Updated•9 years ago
|
Keywords: regressionwindow-wanted
Reporter | ||
Comment 1•9 years ago
|
||
It seems that gettext function in https://github.com/mozilla/buddyup/blob/master/app/js/notifications.js#L64 it is not defined for some reason.
Reporter | ||
Comment 2•9 years ago
|
||
Also is seems that something goes wrong with endpoints as in https://github.com/mozilla/buddyup/blob/master/app/js/notifications.js#L37 most of the times the result is false.
This leads to push_realtime() function where nothing happens if you are not inside the question and this way user can not get notifications that should get.
This maybe is the reason of the strange behavior in the past when notifications didn't appear always in time but in future all together, old and new like in bug 1142155.
Forgot to say that the above have been tested on v2.2 FxOS.
Updated•9 years ago
|
Priority: -- → P2
Whiteboard: u=user p=?
Target Milestone: --- → 2015Q3
Reporter | ||
Updated•9 years ago
|
Summary: Notifications doesn't appear → Notifications don't appear
Updated•9 years ago
|
Whiteboard: u=user p=? → u=user p=1
Comment 3•9 years ago
|
||
PR: https://github.com/mozilla/buddyup/pull/184
Fredy, do the above change fix this problem for you? I'm not set up right not to test notifications.
Assignee: nobody → mcooper
Status: NEW → ASSIGNED
Reporter | ||
Comment 4•9 years ago
|
||
Comment 5•9 years ago
|
||
I still can't get either the simulator or a device to work, so I still can't test this.
Fredy, some other changes have landed on master that could effect this. Can you check those too? The master branch at 33717e78aba29942cc27d496bdb2d437f5e3705f has the changes I'm talking about.
If these don't work either, I'm out of ideas. I'll need to get the simulator working reliably or get a device.
Comment 6•9 years ago
|
||
I still haven't seen any notifications when testing lately using both the Flame and the Z3 device. I am running https://github.com/mozilla/buddyup/commit/33717e78aba29942cc27d496bdb2d437f5e3705f.
Would it be helpful to try to find a regression range for this? I really think we need to escalate this as a blocker with the time we have to left before we will be shipping.
Reporter | ||
Comment 8•9 years ago
|
||
status-b2g-master:
--- → affected
tracking-b2g:
--- → +
Whiteboard: u=user p=1 → u=user p=1 blocking-b2g
Blocks: META_2.5_Release
Assignee | ||
Comment 9•9 years ago
|
||
Assignee | ||
Comment 10•9 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Comment 11•9 years ago
|
||
I did some preliminary testing of this with 2 Flames and a Z3, and while I see notifications on the Flame, I don't see them coming through on the Z3. The Z3 is running the dogfood-latest build which is the latest 2.5 build available. I will try to see if something comes up in logcat or console.
Comment 12•9 years ago
|
||
Oddly, the next time I tested this, I got a whole bunch of notifications that were queued up at once. Now it appears on the Z3 notifications are showing. fredy said he will perform some testing as well, and will verify if we get consistent results.
Comment 13•9 years ago
|
||
Comment from fredy over the weekend:
I still don't get notifications either in device or simulator
I'll do more tests during the weekend
It still seems to be a problem with the endpoints... it seems that the one on my device doesn't agree with the one that gets the notification...
So right now it seems QA is not getting consistent results to verify this bug.
Reporter | ||
Comment 14•9 years ago
|
||
As Marcia said in the previous comment, I get an inconsistent behavior. Sometimes I get notifications as I should, sometimes I don't get them at all.
Note: Notifications aren't lost, so if user is able to get one then all the past, not shown, notifications show up.
Comment 15•9 years ago
|
||
Going to reopen based on fredy's comment - what can QA do to help debug this?
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Comment 16•9 years ago
|
||
The original problem here was a regression that caused all notifications to fail. That problem is fixed, since Fredy can get any notifications at all.
I am very hesitant to blame intermittent failures on BuddyUp. I can't think of a mechanism that would cause notifications to fail sometimes but not others that is in our control. Unfortunately we have no way to test Simple Push or notice errors in it, except in the sending of events (Sumo hasn't reported any errors here lately). All we have is absence of data, and I can't debug that.
The original problem here is fixed. I suggest we open another bug if there is a reliably-reproduced problem we suspect is caused by BuddyUp.
Status: REOPENED → RESOLVED
Closed: 9 years ago → 9 years ago
Resolution: --- → FIXED
Updated•9 years ago
|
Keywords: regressionwindow-wanted
You need to log in
before you can comment on or make changes to this bug.
Description
•