Closed Bug 1202015 Opened 9 years ago Closed 9 years ago

Better document the SRI strings for translators

Categories

(Core :: DOM: Security, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla43
Tracking Status
firefox43 --- fixed

People

(Reporter: francois, Assigned: francois)

References

Details

Attachments

(1 file)

As requested by Stefan in https://bugzilla.mozilla.org/show_bug.cgi?id=992096#c93, we should document what the placeholders are in each of the localizable strings.
Assignee: nobody → francois
Status: NEW → ASSIGNED
Bug 1202015 - Better document the SRI strings for translators. r?ckerschb
Attachment #8657324 - Flags: review?(mozilla)
I also ended up fixing one of the strings because it was still referring to URIs instead of hashes (a leftover from when the SRI spec was using NI URIs).
Comment on attachment 8657324 [details]
MozReview Request: Bug 1202015 - Better document the SRI strings for translators. r?ckerschb

https://reviewboard.mozilla.org/r/18357/#review16583

::: dom/locales/en-US/chrome/security/security.properties:59
(Diff revision 1)
> -MalformedIntegrityURI=The script element has a malformed URI in its integrity attribute: "%1$S". The correct format is "<hash algorithm>-<hash value>".
> +MalformedIntegrityURI=The script element has a malformed hash in its integrity attribute: "%1$S". The correct format is "<hash algorithm>-<hash value>".

Please update to 'MalformedIntegrityHash'. Reason being is that this string might already have been localized and now they don't know that they have to update their local again because the 'variable' name did not change. I had that problem recently.

Then you also have to update usage of it within the code obviously.
r=me with that changed.
Attachment #8657324 - Flags: review?(mozilla) → review+
https://hg.mozilla.org/mozilla-central/rev/6c7d5b56e472
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla43
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: