STR: 1. Open a site 2. Tap site icon to pin 3. Navigate to other page which still within the same site scope 4. Tap site icon to pin again 5. Check homescreen Expected result: 1. 2 pinned site icons exist Actual result: 1. Should only exist one pinned site Build info: [aries] Build ID 20150907110522 Gaia Revision 891798f1e345bc2b69e71de42bd524a90b1745c4 Gaia Date 2015-09-07 02:49:56 Gecko Revision https://hg.mozilla.org/mozilla-central/rev/5fe9ed3edd6811a662d40d05e37b0d66e9520d82 Gecko Version 43.0a1 Device Name aries Firmware(Release) 4.4.2 Firmware(Incremental) eng.worker.20150907.102632 Firmware Date Mon Sep 7 10:26:39 UTC 2015 Bootloader s1 [flame] Build ID 20150907150218 Gaia Revision 891798f1e345bc2b69e71de42bd524a90b1745c4 Gaia Date 2015-09-07 02:49:56 Gecko Revision https://hg.mozilla.org/mozilla-central/rev/5fe9ed3edd6811a662d40d05e37b0d66e9520d82 Gecko Version 43.0a1 Device Name flame Firmware(Release) 4.4.2 Firmware(Incremental) eng.cltbld.20150907.182946 Firmware Date Mon Sep 7 18:29:58 EDT 2015 Bootloader L1TC000118D0

After discussions with UX, this bug is about toggling the pin site button from the pin dialog to pin/unpin.

Let's wait until Bug 1168970 lands before r?.

Comment on attachment 8673672 [details] Github PR Alberto, can you have a look? The failing integration tests are enquired in parrallel.

Comment on attachment 8673672 [details] Github PR It looks good overall, but left a couple of comments in GH. Please, let's add a UI test for unpinning before landing. Thanks!

Note: I have fixed the "new window from the rocketbar" problem [1]. But now the `Tapping the browser opens the last unpinned instance` test is failing. I believe this is a real failure, because manually performing the actions on the device reveal the bug. We have two choices: - fix the bug for bookmarks - convert this test to use pins instead of bookmarks (since pins work for opening the correct window). I think we should do the second option but it might take some additional time. I'll work on this in parallel while Guillaume updates his PR based on Alberto's review. 1.) https://github.com/mikehenrty/gaia/commit/0d251400c0543742ddfe59c3763c318cc9e2bdf0 PR: https://github.com/mozilla-b2g/gaia/pull/32474

Comment on attachment 8674843 [details] [gaia] mikehenrty:bug-1215492-fix-pinning-test > mozilla-b2g:master Sorry, this attachment was meant for bug 1215492.

master: https://github.com/mozilla-b2g/gaia/commit/f19ef3360e345f0d1f3df0b0794c9b4b56699b48

Thanks Michael!

Verified on [Flame] Build ID 20151019150205 Gaia Revision a87f947366c2e044bd6336e1982419ac45378969 Gaia Date 2015-10-19 15:22:08 Gecko Revision https://hg.mozilla.org/mozilla-central/rev/9605da94e75d61598d3c00f01a12d1b6bc427a6c Gecko Version 44.0a1 Device Name flame Firmware(Release) 4.4.2 Firmware(Incremental) eng.cltbld.20151019.182947 Firmware Date Mon Oct 19 18:29:58 EDT 2015 Bootloader L1TC000118D0 [Aries] Build ID 20151019205841 Gaia Revision a87f947366c2e044bd6336e1982419ac45378969 Gaia Date 2015-10-19 15:22:08 Gecko Revision https://hg.mozilla.org/mozilla-central/rev/9605da94e75d61598d3c00f01a12d1b6bc427a6c Gecko Version 44.0a1 Device Name aries Firmware(Release) 4.4.2 Firmware(Incremental) eng.worker.20151019.201730 Firmware Date Mon Oct 19 20:17:38 UTC 2015 Bootloader s1