mozilla::unused is nice but can't be used in (a) C code, and (b) C++ code where linking with unused.o is tricky. Therefore a fallback macro MOZ_UNUSED will be useful. I already have several places where it will be useful.

With all the back and forth on that file, we might as well have fixed it to use write's return value.

Comment on attachment 8658508 [details] [diff] [review] (part 1) - Add MOZ_UNUSED Review of attachment 8658508 [details] [diff] [review]: ----------------------------------------------------------------- ::: mfbt/unused.h @@ +34,5 @@ > +#endif // __cplusplus > + > +// An alternative to mozilla::unused for use in (a) C code and (b) code where > +// linking with unused.o is difficult. > +#define MOZ_UNUSED(expr) \ I almost want to hide this thusly: #ifdef MOZ_MOZILLA_UNUSED_DOESNT_WORK_HERE #define MOZ_UNUSED(expr) ... #undef MOZ_MOZILLA_UNUSED_DOESNT_WORK_HERE #endif (only half joking here).

https://hg.mozilla.org/integration/mozilla-inbound/rev/4805fa9a89fe https://hg.mozilla.org/integration/mozilla-inbound/rev/7a715b603ac0

https://hg.mozilla.org/mozilla-central/rev/4805fa9a89fe https://hg.mozilla.org/mozilla-central/rev/7a715b603ac0