Closed
Bug 1203134
Opened 9 years ago
Closed 9 years ago
[e10s] autocomplete popup covers input box if is bottom of page
Categories
(Core :: Layout: Form Controls, defect)
Tracking
()
RESOLVED
FIXED
mozilla43
People
(Reporter: over68, Assigned: enndeakin)
References
Details
Attachments
(1 file)
(deleted),
patch
|
Felipe
:
review+
|
Details | Diff | Splinter Review |
Steps to reproduce:
1. Go to https://dl.dropboxusercontent.com/u/95157096/85f61cf7/83x7fexjr3.html.
2. Click on the <input> element in bottom of the page.
Actual results:
autocomplete popup covers input box if is bottom of page.
Screenshot https://dl.dropboxusercontent.com/u/95157096/85f61cf7/oboq6ldjmg.png
Comment 1•9 years ago
|
||
Pushlog:
https://hg.mozilla.org/integration/mozilla-inbound/pushloghtml?fromchange=e5738a6a2678&tochange=29ac9cb43e83
Suspect: Bug 1024437
Blocks: 1024437
Status: UNCONFIRMED → NEW
tracking-e10s:
--- → ?
Component: Untriaged → General
Ever confirmed: true
Product: Firefox → Core
Updated•9 years ago
|
Component: General → Layout: Form Controls
Assignee | ||
Comment 2•9 years ago
|
||
This is similar to the one for <select>. I'll take a look.
Assignee: nobody → enndeakin
Updated•9 years ago
|
Assignee | ||
Comment 3•9 years ago
|
||
Assignee | ||
Updated•9 years ago
|
Attachment #8660034 -
Flags: review?(felipc)
Comment 4•9 years ago
|
||
Comment on attachment 8660034 [details] [diff] [review]
Easy fix
Review of attachment 8660034 [details] [diff] [review]:
-----------------------------------------------------------------
::: toolkit/components/satchel/AutoCompleteE10S.jsm
@@ +126,5 @@
> // Reset fields that were set from the last time the search popup was open
> this.popup.mInput = null;
> this.popup.showCommentColumn = false;
> this.popup.showImageColumn = false;
> + this.popup.openPopupAtScreenRect("after_start", this.x, this.y, this.width, this.height, false, false);
nit: whitespace
Attachment #8660034 -
Flags: review?(felipc) → review+
Assignee | ||
Comment 5•9 years ago
|
||
url: https://hg.mozilla.org/integration/mozilla-inbound/rev/d7b18f4aa01089dab89973f19ebb2e2bfc6a56a9
changeset: d7b18f4aa01089dab89973f19ebb2e2bfc6a56a9
user: Neil Deakin <neil@mozilla.com>
date: Mon Sep 14 15:18:42 2015 -0400
description:
Bug 1203134, autocomplete popup not positioned properly when it appears upwards, e10s only, r=felipe
Status: NEW → RESOLVED
Closed: 9 years ago
status-firefox43:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla43
Assignee | ||
Updated•9 years ago
|
Points: --- → 1
You need to log in
before you can comment on or make changes to this bug.
Description
•