Closed Bug 1203267 Opened 9 years ago Closed 9 years ago

Add a requirements.txt file for pinned mozbase packages

Categories

(Testing :: Firefox UI Tests, defect)

43 Branch
defect
Not set
normal

Tracking

(firefox40 fixed, firefox41 fixed, firefox42 fixed, firefox43 fixed, firefox-esr38 fixed)

RESOLVED FIXED
mozilla43
Tracking Status
firefox40 --- fixed
firefox41 --- fixed
firefox42 --- fixed
firefox43 --- fixed
firefox-esr38 --- fixed

People

(Reporter: whimboo, Assigned: whimboo)

References

Details

Attachments

(1 file)

For the execution of our tests through mozharness we need a specific version of all the mozbase modules to reduce the risk of version conflicts in our CI and releng systems. As discussed with Armen the best approach here is to add this file to our test repository. That way we can also have branch specific versions of modules corresponding to the Marionette version.
Blocks: 1203155
Attached file github_pull_request.txt (deleted) —
Not sure if Chris is around or not. If he isn't maybe David can review this patch?
Attachment #8658889 - Flags: review?(dburns)
Attachment #8658889 - Flags: review?(cmanchester)
Comment on attachment 8658889 [details] github_pull_request.txt I would need more context to do this review. I can't tell exactly the problem this is intending to address.
Attachment #8658889 - Flags: review?(cmanchester)
This is still necessary because of the broken version dependency handling of mozbase packages. There is no-one who supports defining upper limits for API compatibility. So whenever a change happens which breaks API it will bust CI systems. And this is very bad! In-tree framework might not be affected but please keep in mind that we are still outside of the tree and using the pypi packages. So conflicts will not be noticed via try or whatever. See bug 1196447 for details. With pinning the mozbase versions we can ensure that exactly those packages are installed which are known to work. Once we bump versions in setup.py or a new version of a dependency gets released which has a feature we need, we can easily bump.
Attachment #8658889 - Flags: review?(cmanchester)
Attachment #8658889 - Flags: review?(dburns) → review+
Comment on attachment 8658889 [details] github_pull_request.txt Thank you David. I think that I can remove the request from Chris now.
Attachment #8658889 - Flags: review?(cmanchester)
Merged PR to master as https://github.com/mozilla/firefox-ui-tests/commit/f91ab2f28da4e62b0fbf79b076e94999dcb7b10e. We need this patch across all branches down to 38esr. Good thing is that we use the same versino of Marionette across all branches. I will do the backport later today.
Target Milestone: --- → Firefox 43
Product: Mozilla QA → Testing
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: