Closed
Bug 1203267
Opened 9 years ago
Closed 9 years ago
Add a requirements.txt file for pinned mozbase packages
Categories
(Testing :: Firefox UI Tests, defect)
Tracking
(firefox40 fixed, firefox41 fixed, firefox42 fixed, firefox43 fixed, firefox-esr38 fixed)
RESOLVED
FIXED
mozilla43
People
(Reporter: whimboo, Assigned: whimboo)
References
Details
Attachments
(1 file)
For the execution of our tests through mozharness we need a specific version of all the mozbase modules to reduce the risk of version conflicts in our CI and releng systems.
As discussed with Armen the best approach here is to add this file to our test repository. That way we can also have branch specific versions of modules corresponding to the Marionette version.
Assignee | ||
Comment 1•9 years ago
|
||
Not sure if Chris is around or not. If he isn't maybe David can review this patch?
Attachment #8658889 -
Flags: review?(dburns)
Attachment #8658889 -
Flags: review?(cmanchester)
Comment 2•9 years ago
|
||
Comment on attachment 8658889 [details]
github_pull_request.txt
I would need more context to do this review. I can't tell exactly the problem this is intending to address.
Attachment #8658889 -
Flags: review?(cmanchester)
Assignee | ||
Comment 3•9 years ago
|
||
This is still necessary because of the broken version dependency handling of mozbase packages. There is no-one who supports defining upper limits for API compatibility. So whenever a change happens which breaks API it will bust CI systems. And this is very bad! In-tree framework might not be affected but please keep in mind that we are still outside of the tree and using the pypi packages. So conflicts will not be noticed via try or whatever. See bug 1196447 for details.
With pinning the mozbase versions we can ensure that exactly those packages are installed which are known to work. Once we bump versions in setup.py or a new version of a dependency gets released which has a feature we need, we can easily bump.
Assignee | ||
Updated•9 years ago
|
Attachment #8658889 -
Flags: review?(cmanchester)
Updated•9 years ago
|
Attachment #8658889 -
Flags: review?(dburns) → review+
Assignee | ||
Comment 4•9 years ago
|
||
Comment on attachment 8658889 [details]
github_pull_request.txt
Thank you David. I think that I can remove the request from Chris now.
Attachment #8658889 -
Flags: review?(cmanchester)
Assignee | ||
Comment 5•9 years ago
|
||
Merged PR to master as https://github.com/mozilla/firefox-ui-tests/commit/f91ab2f28da4e62b0fbf79b076e94999dcb7b10e.
We need this patch across all branches down to 38esr. Good thing is that we use the same versino of Marionette across all branches. I will do the backport later today.
status-firefox40:
--- → affected
status-firefox41:
--- → affected
status-firefox42:
--- → affected
status-firefox-esr38:
--- → affected
Target Milestone: --- → Firefox 43
Assignee | ||
Comment 6•9 years ago
|
||
https://github.com/mozilla/firefox-ui-tests/commit/9d3aba7239cb57f7142f2f11aadf65de20953711 (aurora)
https://github.com/mozilla/firefox-ui-tests/commit/87d8cb4d805b16465c8700bee3ffbedd91e771f6 (beta)
https://github.com/mozilla/firefox-ui-tests/commit/a99bb21b2570bf0e65b769e490d4d2823cba8df9 (release)
https://github.com/mozilla/firefox-ui-tests/commit/a8aaa07cdc3d9203ea5c0f641addaf6d2a7c7044 (esr38)
For esr38 there was a merge conflict with .travis.yml which doesn't exist on that branch. I simply removed the file from the merge.
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Updated•9 years ago
|
Product: Mozilla QA → Testing
You need to log in
before you can comment on or make changes to this bug.
Description
•