Closed
Bug 1203407
Opened 9 years ago
Closed 9 years ago
B2G Installer should allow offline use
Categories
(Firefox OS Graveyard :: B2gInstaller, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: gerard-majax, Assigned: gerard-majax)
References
Details
Attachments
(1 file)
We regressed offline use after landing support for online registry of builds.
STR:
0. Be offline
1. Open about:b2g-installer
2. Plugin device
Expected:
Device serial number is detected and I can select a local blobfree zip file
Actual:
Device serial number does not show and I cannot pick a local blobfree zip file
Comment 1•9 years ago
|
||
Should we just package devices.json inside the addon? people can still contribute to it and we will get nicer device detection etc, having it fetched seems like a mistake in hindsight
Assignee | ||
Comment 2•9 years ago
|
||
(In reply to Dale Harvey (:daleharvey) from comment #1)
> Should we just package devices.json inside the addon? people can still
> contribute to it and we will get nicer device detection etc, having it
> fetched seems like a mistake in hindsight
I think we should just not block user when we have no network and the XHR fails?
Comment 3•9 years ago
|
||
Yup can do that too, we will miss the user friendly device name and it may be nice to at least show the users there are builds available if they were to go online, but those are minor issues. Either way I think it would be an improvement
Assignee | ||
Comment 4•9 years ago
|
||
Attachment #8660661 -
Flags: review?(dale)
Assignee | ||
Comment 5•9 years ago
|
||
(In reply to Dale Harvey (:daleharvey) from comment #3)
> Yup can do that too, we will miss the user friendly device name and it may
> be nice to at least show the users there are builds available if they were
> to go online, but those are minor issues. Either way I think it would be an
> improvement
Added displaying a message to the user. That should be good :)
Comment 6•9 years ago
|
||
Comment on attachment 8660661 [details]
PR
This looks good, thanks
Attachment #8660661 -
Flags: review?(dale) → review+
Assignee | ||
Comment 7•9 years ago
|
||
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•