Closed
Bug 1203454
Opened 9 years ago
Closed 9 years ago
Backout partial visual refresh implementation from Fx42
Categories
(Hello (Loop) :: Client, defect, P1)
Hello (Loop)
Client
Tracking
(firefox41 unaffected, firefox42 verified)
Tracking | Status | |
---|---|---|
firefox41 | --- | unaffected |
firefox42 | --- | verified |
People
(Reporter: standard8, Assigned: standard8)
References
Details
Attachments
(5 files)
(deleted),
patch
|
Sylvestre
:
approval-mozilla-aurora+
|
Details | Diff | Splinter Review |
(deleted),
patch
|
Sylvestre
:
approval-mozilla-aurora+
|
Details | Diff | Splinter Review |
(deleted),
patch
|
Sylvestre
:
approval-mozilla-aurora+
|
Details | Diff | Splinter Review |
(deleted),
patch
|
Sylvestre
:
approval-mozilla-aurora+
|
Details | Diff | Splinter Review |
(deleted),
patch
|
Sylvestre
:
approval-mozilla-aurora+
|
Details | Diff | Splinter Review |
The visual refresh work for Loop started in 42 and has almost finished in 43. However it isn't suitable for uplift, so we need to backout the few bugs that did land in 42.
Assignee | ||
Comment 1•9 years ago
|
||
Approval Request Comment
[Feature/regressing bug #]: FF Hello Visual Refresh, backout patch 1 of 5
[User impact if declined]: Partial refresh implementation landed for 42, but is now being completed for 43 and isn't suitable for uplift. Hence, the current partially done 42 has bad layouts and an incomplete design change.
[Describe test coverage new/current, TreeHerder]: Code has unit tests
[Risks and why]: Low - reverting to the previous version.
[String/UUID change made/needed]: None. Any string changes are not being backed out.
Attachment #8659142 -
Flags: approval-mozilla-aurora?
Assignee | ||
Comment 2•9 years ago
|
||
Approval Request Comment
[Feature/regressing bug #]: FF Hello Visual Refresh, backout patch 2 of 5
[User impact if declined]: Partial refresh implementation landed for 42, but is now being completed for 43 and isn't suitable for uplift. Hence, the current partially done 42 has bad layouts and an incomplete design change.
[Describe test coverage new/current, TreeHerder]: Code has unit tests
[Risks and why]: Low - reverting to the previous version.
[String/UUID change made/needed]: None. Any string changes are not being backed out.
Attachment #8659143 -
Flags: approval-mozilla-aurora?
Assignee | ||
Updated•9 years ago
|
Attachment #8659143 -
Attachment is patch: true
Assignee | ||
Comment 3•9 years ago
|
||
Approval Request Comment
[Feature/regressing bug #]: FF Hello Visual Refresh, backout patch 3 of 5
[User impact if declined]: Partial refresh implementation landed for 42, but is now being completed for 43 and isn't suitable for uplift. Hence, the current partially done 42 has bad layouts and an incomplete design change.
[Describe test coverage new/current, TreeHerder]: Code has unit tests
[Risks and why]: Low - reverting to the previous version.
[String/UUID change made/needed]: None. Any string changes are not being backed out.
Attachment #8659146 -
Flags: approval-mozilla-aurora?
Assignee | ||
Updated•9 years ago
|
Attachment #8659146 -
Attachment is patch: true
Assignee | ||
Updated•9 years ago
|
Attachment #8659143 -
Attachment description: Backout part 1 - bug 1183618 → Backout part 2 - bug 1183618
Assignee | ||
Comment 4•9 years ago
|
||
Approval Request Comment
[Feature/regressing bug #]: FF Hello Visual Refresh, backout patch 4 of 5
[User impact if declined]: Partial refresh implementation landed for 42, but is now being completed for 43 and isn't suitable for uplift. Hence, the current partially done 42 has bad layouts and an incomplete design change.
[Describe test coverage new/current, TreeHerder]: Code has unit tests
[Risks and why]: Low - reverting to the previous version.
[String/UUID change made/needed]: None. Any string changes are not being backed out.
Attachment #8659148 -
Flags: approval-mozilla-aurora?
Updated•9 years ago
|
status-firefox41:
--- → unaffected
status-firefox42:
--- → affected
Assignee | ||
Updated•9 years ago
|
Attachment #8659148 -
Attachment is patch: true
Assignee | ||
Comment 5•9 years ago
|
||
Approval Request Comment
[Feature/regressing bug #]: FF Hello Visual Refresh, backout patch 5 of 5
[User impact if declined]: Partial refresh implementation landed for 42, but is now being completed for 43 and isn't suitable for uplift. Hence, the current partially done 42 has bad layouts and an incomplete design change.
[Describe test coverage new/current, TreeHerder]: Code has unit tests
[Risks and why]: Low - reverting to the previous version.
[String/UUID change made/needed]: None. Any string changes are not being backed out.
Attachment #8659150 -
Flags: approval-mozilla-aurora?
Updated•9 years ago
|
Attachment #8659142 -
Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Updated•9 years ago
|
Attachment #8659143 -
Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Updated•9 years ago
|
Attachment #8659146 -
Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Updated•9 years ago
|
Attachment #8659148 -
Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Updated•9 years ago
|
Attachment #8659150 -
Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Comment 6•9 years ago
|
||
Thanks for creating this new bug, this is appreciated!
Assignee | ||
Comment 7•9 years ago
|
||
https://hg.mozilla.org/releases/mozilla-aurora/rev/fdeacd3d68ad
https://hg.mozilla.org/releases/mozilla-aurora/rev/1b471080813d
https://hg.mozilla.org/releases/mozilla-aurora/rev/01567d5dc281
https://hg.mozilla.org/releases/mozilla-aurora/rev/ea37f9d31481
https://hg.mozilla.org/releases/mozilla-aurora/rev/dc8eaa3246ed
Status: NEW → RESOLVED
Closed: 9 years ago
Rank: 3
Flags: qe-verify+
Priority: -- → P1
Resolution: --- → FIXED
Assignee | ||
Updated•9 years ago
|
Target Milestone: --- → mozilla42
Updated•9 years ago
|
QA Contact: bogdan.maris
Comment 8•9 years ago
|
||
Verified that all the patches were backed out of Firefox 42 beta 2 build 1 across platforms (Windows 7 64-bit, Mac OS X 10.10.5 and Ubuntu 14.04 32-bit) and did not found any new issues.
You need to log in
before you can comment on or make changes to this bug.
Description
•