STR: 1. Have a lot of usernames/passwords. 2. (Not sure if necessary but may help): add a master password 3. Visit about:logins. Actual results: throbber image shows up *with scrollbars around it* for some reason, some of the time. (Not every time I perform STR). See attached screenshot. Expected results: no scrollbars around throbber

I'm using Nightly 2015-09-10 on a OnePlus One, running recent Android (CyanogenMod nightly)

ally, have you seen this?

Come to think of it, I used about:logins this morning and it was slow to load, but I didn't see the loading indicator. Is it broken?

Yeah, actually -- I only see the loading indicator when I need to unlock my master password (and get the prompt). If I unlock my MP, and then re-visit about:logins in a new tab, I get a blank page instead of a throbber while it's loading. Maybe we try to set up the loading indicator asynchronously, in a runnable, but that's accidentally blocked on pageload? (but it's able to proceed if we interrupt pageload to pop up the MP dialog & spin the event loop in the background)

no loading indicator seen on up today's Nightly.

I haven't seen either issue, no. 1 Master Password - We know that Services.logins.getAllLogins() may throw (and we'll quietly catch) if the masterpassword state is not correct. http://mxr.mozilla.org/mozilla-central/source/mobile/android/chrome/content/aboutLogins.js#68 What _may_ be happening in dholbert's case is that getAllLogins() throws, so we think we have no passwords, we set logins = [], and later the observer for password changes triggers and then we update the list, http://mxr.mozilla.org/mozilla-central/source/mobile/android/chrome/content/aboutLogins.js#441. It could also be a case where the cpu is locked up and the animation just isn't really getting drawn. I've heard from nalexander that the svg can get especially janky on older phones and lower end hardware. 2 Bill, are you not seeing it at all, or not seeing it with master password? 3 The scrollbars part should be a wontfix. nalexander is working on converting this spinner to a css animation (that he wants for the about:accounts page he's working on, Bug 1204510). Afaik he hasn't landed any work yet so it couldn't be the cause of 1 & 2. I'll check with him though. In the meantime, Ill see if I can repro.

nalexander confirms nothing has landed. margaret, do you have a master password set?

(In reply to Allison Naaktgeboren please NEEDINFO? :ally from comment #7) > nalexander confirms nothing has landed. > > margaret, do you have a master password set? No, I don't have a master password set. I don't think I've ever seen the throbber load for me... was the fix for bug 1155345 verified? Maybe it didn't work properly?

(In reply to Allison Naaktgeboren please NEEDINFO? :ally from comment #6) > I haven't seen either issue, no. > > 1 Master Password - We know that Services.logins.getAllLogins() may throw > (and we'll quietly catch) if the masterpassword state is not correct. > http://mxr.mozilla.org/mozilla-central/source/mobile/android/chrome/content/ > aboutLogins.js#68 > > What _may_ be happening in dholbert's case is that getAllLogins() throws, so > we think we have no passwords, we set logins = [], and later the observer > for password changes triggers and then we update the list, > http://mxr.mozilla.org/mozilla-central/source/mobile/android/chrome/content/ > aboutLogins.js#441. > > It could also be a case where the cpu is locked up and the animation just > isn't really getting drawn. I've heard from nalexander that the svg can get > especially janky on older phones and lower end hardware. > > 2 Bill, are you not seeing it at all, or not seeing it with master password? > > 3 The scrollbars part should be a wontfix. nalexander is working on > converting this spinner to a css animation (that he wants for the > about:accounts page he's working on, Bug 1204510). Afaik he hasn't landed > any work yet so it couldn't be the cause of 1 & 2. I'll check with him > though. > > In the meantime, Ill see if I can repro. Ally, I don't see it on Nightly either with or without MP enabled.

(In reply to :Margaret Leibovic from comment #8) > (In reply to Allison Naaktgeboren please NEEDINFO? :ally from comment #7) > > nalexander confirms nothing has landed. > > > > margaret, do you have a master password set? > > No, I don't have a master password set. > > I don't think I've ever seen the throbber load for me... was the fix for bug > 1155345 verified? Maybe it didn't work properly? Doesn't look like it was formally verified by QA, or if it was, they did not comment on the bug. I know I've certainly seen the spinner myself in my personal use.

This is the same cause and effect as https://bugzilla.mozilla.org/show_bug.cgi?id=1208534#c1. On Nightly, Bug 1204510 has replaced the SVG spinner with a smooth CSS animation that hits the OMTA pipeline. Bug 1208534 tracks spreading the spinner/load/unspinner across JS ticks so that we get a paint before the janky load operation; since we're hitting the OMTA pipeline, this works well. It's my expectation that the fix from Bug 1208534 will show the spinner, but will not animate it smoothly, since the janky load will block the main-thread SVG animation. That means we either WONTFIX this, or we uplift both Bug 1204510 and Bug 1208534 to Beta. That's not that risky.

How is this bug different than bug 1208534? Can it be duped?

(In reply to :Margaret Leibovic from comment #12) > How is this bug different than bug 1208534? Can it be duped? That one is particular to MP. We can dupe if you care.

I think we can dupe without losing anything