Closed Bug 120383 Opened 23 years ago Closed 22 years ago

make Category at the top of the prefs listing unclickable

Categories

(SeaMonkey :: Themes, defect, P3)

defect

Tracking

(Not tracked)

VERIFIED FIXED
mozilla1.1alpha

People

(Reporter: bugzilla, Assigned: janv)

Details

(Keywords: polish, Whiteboard: [adt3])

Attachments

(2 files, 2 obsolete files)

spun of off bug 118154. is there any way to make the Category label in the prefs dialog non-clickable? it doesn't sort, after all...
jan, feel to reassign, if you wish...
Keywords: polish
accepting
Status: NEW → ASSIGNED
Priority: -- → P3
Target Milestone: --- → mozilla1.0
Attached patch Proposed patch (obsolete) (deleted) — Splinter Review
This just restricts the clicking effect to sortDirectionIndicator columns.
Keywords: patch, review
Comment on attachment 67721 [details] [diff] [review] Proposed patch neil, your patch has some issues. e.g. thread and flagged column in thread pane is not clickable, clicking on column picker enlarges it etc.
Attachment #67721 - Flags: needs-work+
I think, it would be better to just hide column header. Moving to 1.1.alpha for now
Target Milestone: mozilla1.0 → mozilla1.1alpha
i wouldn't mind if the column header were hidden. also compare with the Mailnews acct settings window, where there is no column header.
Depends on: 117921
Works in my skin, I'll look at classic and modern again. Patch bitrotted anyway.
Component: Preferences → Themes
No longer depends on: 117921
Attached patch Updated patch (obsolete) (deleted) — Splinter Review
Attachment #67721 - Attachment is obsolete: true
Attachment #83327 - Attachment is obsolete: true
Nominating for buffy. We might want accept Neil's patch or hide column header entirely.
Keywords: nsbeta1
Nav triage team: nsbeta1+/adt3
Keywords: nsbeta1nsbeta1+
Whiteboard: [adt3]
Ok, here is my plan: Take Neil's patch and also replace column header with <label> like it was before Neil, I've just tried your patch, looks good. Although I found a little bug, click on column picker in folder pane, I don't know why column picker gets wider. Other column pickers work ok.
Comment on attachment 90225 [details] [diff] [review] Looks like sortDirectionIndicator is deprecated I figured out where was the problem >-.treecol-image:hover:active { >+.treecol-image[sort]:hover:active, >+tree[enableColumnDrag] > treecols > .treecol-image:hover:active { > padding: 1px 1px 0px 2px; > } > adding |treecolpicker| fixes the problem However, I don't think this patch is ready. What about trees which use own view implementation, so they don't use |sort| attribute to indicate sorting.
Attachment #90225 - Flags: needs-work+
Attached patch new patch (deleted) — Splinter Review
This patch just hides tree col header and replaces it with a label
sairuh, could you review the last patch ? thanks
Comment on attachment 93164 [details] [diff] [review] new patch sr=bzbarsky
Attachment #93164 - Flags: superreview+
Checked in.
Status: ASSIGNED → RESOLVED
Closed: 22 years ago
Resolution: --- → FIXED
vrfy'd fixed with 2002.09.16.08 builds.
really verifying...
Status: RESOLVED → VERIFIED
Product: Core → SeaMonkey
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: