Closed
Bug 1203915
Opened 9 years ago
Closed 9 years ago
Re-allow submitting add-ons with GUIDs longer than 64 chars
Categories
(addons.mozilla.org Graveyard :: Developer Pages, defect)
addons.mozilla.org Graveyard
Developer Pages
Tracking
(Not tracked)
VERIFIED
FIXED
44.1
People
(Reporter: magopian, Assigned: magopian)
References
Details
This is to re-allow the submission of add-ons/files with GUIDs longer than 64 chars, once Firefox is able to deal with signatures' CN which contains the hash of those GUIDs instead of the GUIDs themselves. It's reverting bug 1202016 once bug 1203365 (on amo) and bug 1203787 (on Firefox) are implemented.
Assignee | ||
Updated•9 years ago
|
Comment 2•9 years ago
|
||
Maybe we should remove the dep on 1203787, since it will behind a waffle flag, and people will want it for testing on dev before that has landed.
Assignee | ||
Updated•9 years ago
|
Assignee: nobody → mathieu
Comment 4•9 years ago
|
||
Commits pushed to master at https://github.com/mozilla/olympia https://github.com/mozilla/olympia/commit/0e30d41a3ce0340e52fb3a44c0908d743d56f9d3 Allow add-ons with long GUIDs with the allow-long-addon-guid waffle switch (bug 1203915) https://github.com/mozilla/olympia/commit/a926e1d7f2323c778e638bf82483ae45372608f3 Merge pull request #741 from magopian/1203915-allow-long-addon-guid Allow add-ons with long GUIDs with the allow-long-addon-guid waffle switch (bug 1203915)
Assignee | ||
Updated•9 years ago
|
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → 44.1
Assignee | ||
Comment 5•9 years ago
|
||
STR: this needs the "long-addon-guid" waffle switch to be turned on, we need to check with Krupa how we want to qualify that
Flags: needinfo?(krupa.mozbugs)
Comment 6•9 years ago
|
||
Mathieu, If I upload an add-on with a 65 char GUID and make sure it can be approved, installed and updated - will that suffice? If yes, I can check that on Monday.
Flags: needinfo?(krupa.mozbugs)
Assignee | ||
Comment 7•9 years ago
|
||
It won't be installed/updated until bug 1203787 has landed. It should however be possible to approve and sign it, yes (and if you attach it to the bug, we should even be able to double check that the signature contains the proper hashed guid as the CN)
Comment 8•9 years ago
|
||
Verified as fixed following comment #6 The addon used is https://addons-dev.allizom.org/en-US/firefox/addon/longid/ Mathieu, Can you please let me know if the signature is ok in order to close the bug?
Flags: needinfo?(mathieu)
Assignee | ||
Comment 9•9 years ago
|
||
Downloaded the add-on, and the CN is: 490b8fca800d778d4b32b3d5cecd0184f6a2b8f14e7f56aaa8e78c97d9eab865 The guid is: aasnbsdbvsasssdssaasnbsdbvsasssdssaasnbsdbvsasssdssaasnbsdbvsasssdssaasnbsdbvsasssdssaasnbsdbvsasssdssaasnbsdbvsasssdss@assasa.com And the sha256 of this guid is indeed what is in the CN. So the signature looks ok.
Flags: needinfo?(mathieu)
Updated•9 years ago
|
Product: addons.mozilla.org → addons.mozilla.org Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•