Closed
Bug 1203969
Opened 9 years ago
Closed 6 years ago
MozReview should provide a better way to indicate which file you're looking at
Categories
(MozReview Graveyard :: Review Board: Upstream, defect)
MozReview Graveyard
Review Board: Upstream
Tracking
(Not tracked)
RESOLVED
INVALID
People
(Reporter: kats, Unassigned)
References
Details
(Whiteboard: [to be fixed in core])
Right now if I'm reviewing a patch that touches a lot of files, and I'm looking at a random part of the patch, it's hard to tell which file I'm in. In splinter view on Bugzilla I would usually navigate using the per-file diffs so it was a lot easier to know which file I was looking at, and if I forgot I could just scroll back up to the top of the page to find out. In MozReview scrolling back to the top doesn't tell me anything and I just lose my place. What would be nice is if the header for each file diff section was position:sticky or something so that as I scroll within that file's diff it is always visible.
Comment 1•9 years ago
|
||
+1 See also my related request in bug 1178030 to allow marking individual files as having been reviewed, the way you can in Splinter.
Reporter | ||
Updated•9 years ago
|
Comment 2•9 years ago
|
||
Filed this as a Review Board core bug: https://hellosplat.com/s/beanbag/tickets/4060/ It's probably best fixed in core, but we could probably hack something up if it's not desired there.
Whiteboard: [to be fixed in core]
Assignee | ||
Updated•9 years ago
|
Product: Developer Services → MozReview
Updated•9 years ago
|
Component: General → Review Board: Upstream
Comment 3•9 years ago
|
||
See also bug 1115705, which arguably eliminates the need for this bug, and which I'd like to implement soonish, given that a number of people have asked for it.
Comment 4•6 years ago
|
||
MozReview is now obsolete. Please use Phabricator instead. Closing this bug.
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → INVALID
You need to log in
before you can comment on or make changes to this bug.
Description
•