Closed
Bug 1204154
Opened 9 years ago
Closed 9 years ago
Clean up jar manifests that needlessly specify the source file
Categories
(Firefox :: General, defect)
Firefox
General
Tracking
()
RESOLVED
FIXED
Firefox 43
Tracking | Status | |
---|---|---|
firefox43 | --- | fixed |
People
(Reporter: Dolske, Unassigned)
Details
Attachments
(1 file)
(deleted),
patch
|
dao
:
review+
|
Details | Diff | Splinter Review |
JAR manifests (as I understand them!) don't need to specify the source file when it's in the same location as the manifest, and the same name as we want to ship it. In other words, a line like
skin/classic/browser/browser.css (browser.css)
can simply be
skin/classic/browser/browser.css
I think the former form has been frequently cargo-culted, and we can make the manifests a bit nicer by removing the duplication.
Attachment #8660204 -
Flags: review?(dtownsend)
Comment 1•9 years ago
|
||
Comment on attachment 8660204 [details] [diff] [review]
Patch v.1
>+If the JAR manifest and packaged file live in the same directory, the path and
>+parenthesis can be omitted. In other words, the following two lines are
>+equivalent::
>+
>+ path/in/jar/same_place.xhtml (same_place.xhtml)
>+ path/in/jar/same_place.xhtml
>+
Nit: reduce indentation by two spaces
Attachment #8660204 -
Flags: review?(dtownsend) → review+
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 43
You need to log in
before you can comment on or make changes to this bug.
Description
•