Right now there are a few[0] places that push gc psuedo frames from various dom gc triggers, but we should just always push psuedo frames when gcing. [0] https://dxr.mozilla.org/mozilla-central/search?q=js%3A%3AProfileEntry%3A%3ACategory%3A%3AGC&redirect=true&case=false&limit=87&offset=0

Comment on attachment 8660283 [details] [diff] [review] Push SPS psuedo frame entries when GCing Review of attachment 8660283 [details] [diff] [review]: ----------------------------------------------------------------- Actually, I think this belongs in AutoTraceSession.

Comment on attachment 8660886 [details] [diff] [review] Push SPS psuedo frame entries when GCing Review of attachment 8660886 [details] [diff] [review]: ----------------------------------------------------------------- Great! That's infinitely better.

Try push: https://treeherder.mozilla.org/#/jobs?repo=try&revision=d6e2aaea3e39

Hi, this failed to apply: adding 1204169 to series file renamed 1204169 -> Bug-1204169---Push-SPS-psuedo-frame-entries-when-G.patch applying Bug-1204169---Push-SPS-psuedo-frame-entries-when-G.patch patching file js/src/gc/GCInternals.h Hunk #1 FAILED at 50 1 out of 1 hunks FAILED -- saving rejects to file js/src/gc/GCInternals.h.rej patch failed, unable to continue (try -v) patch failed, rejects left in working directory errors during apply, please fix and refresh Bug-1204169---Push-SPS-psuedo-frame-entries-when-G.patch could you take a look, thanks!

Backed out for Werror bustage along with bug 1074935: https://hg.mozilla.org/integration/mozilla-inbound/rev/60adc85f21cb https://treeherder.mozilla.org/logviewer.html#?job_id=14289237&repo=mozilla-inbound

Try push: https://treeherder.mozilla.org/#/jobs?repo=try&revision=9edfc8bd9561