See bug 1204167 comment 3.

This commit renames ProfileEntry::set{Js,Cpp}Frame methods to ProfileEntry::init{Js,Cpp}Frame to highlight the fact that they are intended to initialize the entry, and that setting other flags should happen after one of these calls.

Verified that this also fixes bug 1164344 and that the category information is indeed passed along now.

Comment on attachment 8662083 [details] [diff] [review] Ensure that entries created by AutoSPSEntry propogate their category information Review of attachment 8662083 [details] [diff] [review]: ----------------------------------------------------------------- ::: js/public/ProfilingStack.h @@ +134,5 @@ > return flags_ & CATEGORY_MASK; > } > void setCategory(Category c) volatile { > + MOZ_ASSERT(c != Category::FIRST); > + MOZ_ASSERT(c != Category::LAST); This assert seems wrong to me. FIRST and LAST are valid categories (aliases for OTHER and EVENTS). Shouldn't it be something like: MOZ_ASSERT(c >= Category::FIRST && c <= Category::LAST) ??

This commit renames ProfileEntry::set{Js,Cpp}Frame methods to ProfileEntry::init{Js,Cpp}Frame to highlight the fact that they are intended to initialize the entry, and that setting other flags should happen after one of these calls.

This commit renames ProfileEntry::set{Js,Cpp}Frame methods to ProfileEntry::init{Js,Cpp}Frame to highlight the fact that they are intended to initialize the entry, and that setting other flags should happen after one of these calls.

Try push: https://treeherder.mozilla.org/#/jobs?repo=try&revision=08d5c8ba076d