Alastor Wu [:alwu] Assignee
	Description • 9 years ago

User scenario.
1. Play music in background
2. Watch silent video in other app (ex. FB would autoplay the silent video)

Expected.
3. Music should not be interrupted.

We need the patch and test for this scenario.

---

[Conclusion]
If the audio/video is playing, unregister agent when,
(1) It is muted.
(2) Its volume becomes ZERO.

If the audio/video is playing, register agent when,
(1) It is unmuted.
(2) Its volume becomes NON-ZERO.

	Alastor Wu [:alwu] Assignee
	Comment 1 • 9 years ago

Already be done in the current master.

	Alastor Wu [:alwu] Assignee
	Comment 2 • 9 years ago

But we have no the test for this case yet, reopen it and change the tittle.

	Alastor Wu [:alwu] Assignee
	Comment 3 • 9 years ago

Bug 1204793 - testcase for checking the agent active state when changing the volume.

	Alastor Wu [:alwu] Assignee
	Comment 4 • 9 years ago

Try-server result.
https://treeherder.mozilla.org/#/jobs?repo=try&revision=5e61bada6969

	Alastor Wu [:alwu] Assignee
	Comment 5 • 9 years ago

Comment on attachment 8688914 [details]
MozReview Request: Bug 1204793 - testcase for checking the agent active state when changing the volume.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/25447/diff/1-2/

	Andrea Marchesini [:baku]
	Comment 6 • 9 years ago

Comment on attachment 8688914 [details]
MozReview Request: Bug 1204793 - testcase for checking the agent active state when changing the volume.

https://reviewboard.mozilla.org/r/25447/#review23047

We do have a similar test: test_noAudioNotificationOnMutedOrVolume0Element.html

	Alastor Wu [:alwu] Assignee
	Comment 7 • 9 years ago

Ah, sorry I didn't notice that!r
If I change this test to check whether the "activitychange" can be sent correctly, do you think is that ok?

	Andrea Marchesini [:baku]
	Comment 8 • 9 years ago

Sure.

	Alastor Wu [:alwu] Assignee
	Comment 9 • 9 years ago

Comment on attachment 8688914 [details]
MozReview Request: Bug 1204793 - testcase for checking the agent active state when changing the volume.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/25447/diff/1-2/

	Alastor Wu [:alwu] Assignee
	Comment 10 • 9 years ago

Comment on attachment 8688914 [details]
MozReview Request: Bug 1204793 - testcase for checking the agent active state when changing the volume.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/25447/diff/2-3/

	Alastor Wu [:alwu] Assignee
	Comment 11 • 9 years ago

Comment on attachment 8688914 [details]
MozReview Request: Bug 1204793 - testcase for checking the agent active state when changing the volume.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/25447/diff/3-4/

	Alastor Wu [:alwu] Assignee
	Comment 12 • 9 years ago

Comment on attachment 8688914 [details]
MozReview Request: Bug 1204793 - testcase for checking the agent active state when changing the volume.

Hi, Baku,
I modified this patch to check "activitychange" event when the muted or volume changing.
Could you help me review it again?
Very appreciate!

	Alastor Wu [:alwu] Assignee
	Comment 13 • 9 years ago

https://treeherder.mozilla.org/#/jobs?repo=try&revision=bb3039272b2f

	Alastor Wu [:alwu] Assignee
	Comment 14 • 9 years ago

Comment on attachment 8688914 [details]
MozReview Request: Bug 1204793 - testcase for checking the agent active state when changing the volume.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/25447/diff/3-4/

	Andrea Marchesini [:baku]
	Comment 15 • 9 years ago

Comment on attachment 8688914 [details]
MozReview Request: Bug 1204793 - testcase for checking the agent active state when changing the volume.

https://reviewboard.mozilla.org/r/25447/#review26343

	Alastor Wu [:alwu] Assignee
	Comment 16 • 9 years ago

Thanks :)

	Pulsebot
	Comment 17 • 9 years ago

https://hg.mozilla.org/integration/mozilla-inbound/rev/7b7b730f7f8e

	Ryan VanderMeulen [:RyanVM]
	Comment 18 • 9 years ago
bugherder

https://hg.mozilla.org/mozilla-central/rev/7b7b730f7f8e