Closed
Bug 1204897
Opened 9 years ago
Closed 9 years ago
Intermittent test_bug332655-1.html | space after LTR + RTL shouldn't change direction: expected
Categories
(Core :: Layout, defect)
Core
Layout
Tracking
()
RESOLVED
FIXED
mozilla46
People
(Reporter: cbook, Assigned: dholbert)
References
()
Details
(Keywords: intermittent-failure)
Attachments
(1 file)
(deleted),
patch
|
jfkthame
:
review+
|
Details | Diff | Splinter Review |
https://treeherder.mozilla.org/logviewer.html#?job_id=14131969&repo=mozilla-inbound
05:49:43 INFO - 246 INFO TEST-UNEXPECTED-FAIL | layout/base/tests/test_bug332655-1.html | space after LTR + RTL shouldn't change direction: expected data:image/png;base64,iVBORw0KGgoAAAANSUhEUgAAAfQAAAEsCAYAAAA1u0HIAAAJx0lEQVR4nO3d225U9xnGYe4G+x5KrmBObc6roOY+uo2U3EKbk+Q2qrCxmwAKmNBipVV70gg83uDtbAz6ehIqY8941mw8Zl6eR/qEWfOftdZgaf1mY+EbBQAsvBvXfQIAwPQEHQACCDoABBB0AAgg6AAQQNABIICgA0AAQQeAAIIOAAEWLug3buxe9ykAwAenUdBv3Nj9/8xy7STO73fQsWZ9/LOP6fx8CJqe16zXDVvfZH/TrAPgosav0McN+jwNi8M8jnHdwRkVx1mua3LsYduauO5/S4BFNlbQz/456ZqrcF1Bv4rjjKvJ9+Mq1l22VtAB5m+uQZ/0Ldez+x3n1eMk5zDqsTU99riv6Md5vNOe8yzWzeLfbtJ1AFw0dtDPfz3J7cO2zWrNOPuaJjajAj3OfsbZdxNXEdFB3+MmT5Cafi7u83OAyc0l6OO8jXv+tlkGfdzjDzqXpsGZxdvR4wataQgnDeb57/Esn1yNsw2AiyYK+vm/j4rUNEGf5bZxj99k3bTbZxn0Se476bpZnLe34gFm54MN+izesh60bdK3dWfxxGPQ9qsK+jj3b/KKfpz7CDrA/E0c9HfbJv3ce9R+p13f9BwEfbZPuGZ13EnWAXzMPrigj/rcXNAnO69Jzn8WH5Vc1fkB8L6pgj7O2lltmyboTbYNc1mgmwax6ROgcc5tnCdV0x67yZORSY87zvkBcNFc/+vXUZ9dD/uM+93aQfdtum3Y8Zs8rlHn1fR+lx1v2Nommp5Xk3WXPdZJvqezPj8ABlu4X87yMRE0AJoaGfRRr9iMmdcAMJxX6B8I8QJgGoIOAAEEHQACCDoABBB0AAgg6AAQQNABIICgA0AAQQeAAIIOAAEEHQACCDoABBB0AAgg6AAQQNABIICgA0AAQQeAAIIOAAEaBf3w4KC221vV3nppjLmm2W5v1dHRwVVfE4AFNTLoh4cHtdveqn/8+Q/14M4n9deVZWPMnOfBnU/qxV/+VLvtrTo8FHXgopFB32m/qs2vPq8nv/u09jbW6vjZeh398K0xZk5z/Gy9djfW6offflqbX31eO9vteVwbgAUzMujtrZe1dudW7W2s1/FPT+vk4HWdnJxcmFarNXC7MWbKOXhdxz89rb2NtVq780m1t17O49oALJiRQd/eell3V5br+Mf16hzuV6fTGTitVmvobcaY6ebk4HWd/Pi3uruyXNuCDgzQ4BX6q7q3slzHT+5eesERdGOudo6f3K17K8vV3no1j2sDsGBGB739qu6vLNfJ03vV7XaHTqvVuvR2Y8x0c/L0Xt1fWa52W9CBixr9UNyD1aU6eXqvWq3We3P2YnP+tlGBb7J+2D48eTAf45w8vVcPVpdqR9CBARoEvV1rq0vV2bhfvV7vvWm1WgO/vmzbZdN0H+Pu15iE6Wzcr7XVpdpp+yl34KLRQd9p1/qEQb9s+zhrz28XdPMxTmfjfq2vLtXOjqADF40M+u7Odn33S9AHvU3e7/er3++/9/XZGba96dp325ocy5jk6Wzcr+9Wl2p3Z3se1wZgwYwM+uvdnfp+dalarVadnp6+N2e3Dbr9su1N1g7a/zj7MyZpus8e1PerS/V6d2ce1wZgwYwO+t5uPbx989qDPu6+jEmb7rMH9fD2zXq9tzuPawOwYEYGfX9/rx79EvQ3b968N2e3jbq9yZxfP4t9GpMyvR/X6tHtm7W/vzePawOwYEb/cpaD/Xp8+2b1Xjwc+Bn6u4vNZbcNmkHrB+1z2H2v++JqzDzntHNc/ReP6vHtm3V4sD+PawOwYEYG/ejwsJ795ld1svmw+v/5e73tdert27fGmDnNm+5J9f/9vI5fPKxnn92qo8PDeVwbgAUzMugnx8f18zdf1r/+eKc6m4/qdPNx9Z+vG2PmNKebj6uz+bD++ftf13+//qKOj47mcW0AFszIoPd63XrT7dTPX39Rzz+7VU9u3zTGzHmef3arfv7myzrtdqrX687j2gAsmJFBr6rq93vV7XarZ4y5tul2u9Xv9676mgAsqEZBBwA+bIIOAAEEHQACCDoABBB0AAgg6AAQQNABIICgA0AAQQeAAIIOAAEEHQACCDoABBB0AAgg6AAQQNABIICgA0AAQQeAAIIOAAEEHQACCDoABBB0AAgg6AAQQNABIICgA0AAQQeAAIIOAAEEHQACCDoABBB0AAgg6AAQQNABIICgA0AAQQeAAIIOAAEEHQACCDoABBB0AAgg6AAQQNABIICgA0AAQQeAAIIOAAEEHQACCDoABBB0AAgg6AAQQNABIICgA0AAQQeAAIIOAAEEHQACCDoABBB0AAgg6AAQQNABIICgA0AAQQeAAIIOAAEEHQACCDoABBB0AAgg6AAQQNABIICgA0AAQQeAAIIOAAEEHQACCDoABBB0AAgg6AAQQNABIICgA0AAQQeAAIIOAAEEHQACCDoABBB0AAgg6AAQQNABIICgA0AAQQeAAIIOAAEEHQACCDoABBB0AAgg6AAQQNABIICgA0AAQQeAAIIOAAEEHQACCDoABBB0AAgg6AAQQNABIICgA0AAQQeAAIIOAAEEHQACCDoABBB0AAgg6AAQQNABIICgA0AAQQeAAIIOAAEEHQACCDoABBB0AAgg6AAQQNABIICgA0AAQQeAAIIOAAEEHQACCDoABBB0AAgg6AAQQNABIICgA0AAQQeAAIIOAAEEHQACCDoABBB0AAgg6AAQQNABIICgA0AAQQeAAIIOAAEEHQACCDoABBB0AAgg6AAQQNABIICgA0AAQQeAAIIOAAEEHQACCDoABBB0AAgg6AAQQNABIICgA0AAQQeAAIIOAAEEHQACCDoABBB0AAgg6AAQQNABIICgA0AAQQeAAIIOAAEEHQACCDoABBB0AAgg6AAQQNABIICgA0AAQQeAAIIOAAEEHQACCDoABBB0AAgg6AAQQNABIICgA0AAQQeAAIIOAAEEHQACCDoABBB0AAgg6AAQQNABIICgA0AAQQeAAIIOAAEEHQACCDoABBB0AAgg6AAQQNABIICgA0AAQQeAAIIOAAEEHQACCDoABBB0AAgg6AAQQNABIICgA0AAQQeAAIIOAAEEHQACCDoABBB0AAgg6AAQQNABIICgA0AAQQeAAIIOAAEEHQACCDoABBB0AAgg6AAQQNABIICgA0AAQQeAAIIOAAEEHQACCDoABBB0AAgg6AAQQNABIICgA0AAQQeAAIIOAAEEHQACCDoABBB0AAgg6AAQQNABIICgA0AAQQeAAIIOAAEEHQACCDoABBB0AAgg6AAQQNABIICgA0AAQQeAAIIOAAEEHQACCDoABBB0AAgg6AAQ4H8UeXRibnsBFgAAAABJRU5ErkJggg== but got data:image/png;base64,iVBORw0KGgoAAAANSUhEUgAAAfQAAAEsCAYAAAA1u0HIAAAJkklEQVR4nO3d3W4T+R3H4dwN4R5KuQGfEs4rleVGdrVSxd5Eu9xGVRKS3Q1oSQIVaF/aIw4pJZ7xS0L+PdilyoudmbEdJ/7yPNJPhPHfM2OizMcvAtYKALDy1q77BACA+Qk6AAQQdAAIIOgAEEDQASCAoANAAEEHgACCDgABBB0AAqxc0NfW3l33KQDAjdMq6Gtr7/4/i1w7i/P7nXSsRR//9GM6PzdB2/Na9Lpp69vsb551AFzU+hV616Av07Q4LOMY1x2cpjgucl2bY0/b1sZ1/1kCrLJOQT/966xrrsJ1Bf0qjtNVm+/HVay7bK2gAyzfUoM+61uup/fb5dXjLOfQ9NjaHrvrK/ouj3fec17EukX82c26DoCLOgf9/Nez3D5t26LWdNnXPLFpCnSX/XTZdxtXEdFJ3+M2T5Dafi7u83OA2S0l6F3exj1/2yKD3vX4k86lbXAW8XZ016C1DeGswTz/PV7kk6su2wC4aKagn/99U6TmCfoit3U9fpt1825fZNBnue+s6xZx3t6KB1icGxv0RbxlPWnbrG/rLuKJx6TtVxX0Lvdv84q+y30EHWD5Zg76p22zfu7dtN9517c9B0Ff7BOuRR13lnUAn7MbF/Smz80FfbbzmuX8F/FRyVWdHwBnzRX0LmsXtW2eoLfZNs1lgW4bxLZPgLqcW5cnVfMeu82TkVmP2+X8ALhoqf/0a9Nn19M+4/60dtJ9226bdvw2j6vpvNre77LjTVvbRtvzarPussc6y/d00ecHwGQr95+zfE4EDYC2GoPe9IrNmGUNANN5hX5DiBcA8xB0AAgg6AAQQNABIICgA0AAQQeAAIIOAAEEHQACCDoABBB0AAgg6AAQQNABIICgA0AAQQeAAIIOAAEEHQACCDoABBB0AAjQKuij0ajUdVWqqm+Muaap66qMx6OrviYAK6ox6KPRqNSHH8rPf/1L2X5wt/z93m1jzJJn+8Hd8svfHpX68EMZjUQduKgx6HXVL79++03Z/+qL8p/97VId7JT+j/8wxixpqoOd8m5/u+x9+aD8+u03pa6rZVwbgBXTGPR+/7DsPPhjeX/wXal+2iv1h/elrusL0+v1Jm43xsw5H96X6qe98v5gp+w8uFv6/cNlXBuAFdMY9Kp/WJ7cu12qlztlcPjfMhgMJk6v15t6mzFmvqk/vC/1y+9++1kUdGCCVq/QN+/dLtWLJ5decATdmKud6sWTsnnvtlfowEStgr5173ap9zbLcDicOr1e79LbjTHzTb23WbYEHZii1VvuTzfWS723WXq93pk5fbE5f1tT4Nusn7YPTx7M5zj13mZ5urHuLXdgohZB75ftjfUy2N8qo9HozPR6vYlfX7btsmm7j677NSZhBvtbZXtjvVT9/jKuDcCKaQ561S87Mwb9su1d1p7fLujmc5zB/lbZ2VgvVSXowEUt/h56Vb7/PeiT3iYfj8dlPB6f+fr0TNvedu2nbW2OZUzyDPa3yvcb66Wu/D104KLGoA/qqvywsV56vV45Ojo6M6e3Tbr9su1t1k7af5f9GZM0w4On5YeN9TLwD8sAEzQHfVCX3fu3rj3oXfdlTNoMD56W3fu3ymBQL+PaAKyYxqAPh4Py7PegHx8fn5nT25pubzPn1y9in8akzOjldnl2/1YZDgfLuDYAK6bFf84yLM/v3yqj17sTP0P/dLG57LZJM2n9pH1Ou+91X1yNWeYcDaoyfv3st5/F0XAZ1wZgxTQGfTwel4Mv/lDqN7tl/O9/lo+jQfn48aMxZklzPKzL+F+vSvV6txw8vFPG4/Eyrg3AimkM+vHxcXn7+FH55es/l8GbZ+XozfMyfrVjjFnSHL15XgZvdsvPX/2pvH38qBwdHS3j2gCsmMagn5yclI+jYXn7+FF59fBOeXH/ljFmyfPq4Z3y9vGjcjwalpOTk2VcG4AV0xj0T05OTowx1zwA07QOOgBwcwk6AAQQdAAIIOgAEEDQASCAoANAAEEHgACCDgABBB0AAgg6AAQQdAAIIOgAEEDQASCAoANAAEEHgACCDgABBB0AAgg6AAQQdAAIIOgAEEDQASCAoANAAEEHgACCDgABBB0AAgg6AAQQdAAIIOgAEEDQASCAoANAAEEHgACCDgABBB0AAgg6AAQQdAAIIOgAEEDQASCAoANAAEEHgACCDgABBB0AAgg6AAQQdAAIIOgAEEDQASCAoANAAEEHgACCDgABBB0AAgg6AAQQdAAIIOgAEEDQASCAoANAAEEHgACCDgABBB0AAgg6AAQQdAAIIOgAEEDQASCAoANAAEEHgACCDgABBB0AAgg6AAQQdAAIIOgAEEDQASCAoANAAEEHgACCDgABBB0AAgg6AAQQdAAIIOgAEEDQASCAoANAAEEHgACCDgABBB0AAgg6AAQQdAAIIOgAEEDQASCAoANAAEEHgACCDgABBB0AAgg6AAQQdAAIIOgAEEDQASCAoANAAEEHgACCDgABBB0AAgg6AAQQdAAIIOgAEEDQASCAoANAAEEHgACCDgABBB0AAgg6AAQQdAAIIOgAEEDQASCAoANAAEEHgACCDgABBB0AAgg6AAQQdAAIIOgAEEDQASCAoANAAEEHgACCDgABBB0AAgg6AAQQdAAIIOgAEEDQASCAoANAAEEHgACCDgABBB0AAgg6AAQQdAAIIOgAEEDQASCAoANAAEEHgACCDgABBB0AAgg6AAQQdAAIIOgAEEDQASCAoANAAEEHgACCDgABBB0AAgg6AAQQdAAIIOgAEEDQASCAoANAAEEHgACCDgABBB0AAgg6AAQQdAAIIOgAEEDQASCAoANAAEEHgACCDgABBB0AAgg6AAQQdAAIIOgAEEDQASCAoANAAEEHgACCDgABBB0AAgg6AAQQdAAIIOgAEEDQASCAoANAAEEHgACCDgABBB0AAgg6AAQQdAAIIOgAEEDQASCAoANAAEEHgACCDgABBB0AAgg6AAQQdAAIIOgAEEDQASCAoANAAEEHgACCDgABBB0AAgg6AAQQdAAIIOgAEEDQASCAoANAAEEHgACCDgABBB0AAgg6AAQQdAAIIOgAEEDQASCAoANAAEEHgACCDgABBB0AAgg6AAQQdAAIIOgAEEDQASCAoANAAEEHgACCDgABBB0AAgg6AAQQdAAIIOgAEEDQASCAoANAAEEHgACCDgABBB0AAgg6AAQQdAAIIOgAEEDQASCAoANAAEEHgACCDgABBB0AAgg6AAQQdAAIIOgAEEDQASCAoANAgP8Bnv6knoJ+q6AAAAAASUVORK5CYII=
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Assignee | ||
Comment 16•9 years ago
|
||
Looking at the first 2 mismatching data URIs from the first log[1] in comment 15's orangefactor link: these are input fields with a gradient background (from the native theming), and the gradient is positioned 1px higher in the "expected" snapshot as compared to the "but got" snapshot.
As philor already noted here (via a dependency), this is a version of bug 1223198, since this is linux+ASAN-specific and since this seems to have gotten bad (in comment 3) around when that bug was filed.
So, the real fix is for someone to figure out bug 1223198. In the meantime: since this is a particularly frequent orange and this mochitest isn't intending to specifically test native widget rendering, we can probably work around this by using an unthemed widget in this mochitest. (-moz-appearance: none)
[1] https://treeherder.mozilla.org/logviewer.html#?repo=mozilla-inbound&job_id=18530884
Assignee | ||
Comment 17•9 years ago
|
||
Here's a workaround to stop the oranges, per comment 16.
(Kind of a paper-over, but not really because the test will still test what it intends to test, without triggering this tangential & barely-noticeable GTK+ASAN-only rendering glitch. And bug 1223198 still covers that issue.)
Attachment #8701357 -
Flags: review?(jfkthame)
Assignee | ||
Updated•9 years ago
|
Assignee: nobody → dholbert
Status: NEW → ASSIGNED
Comment hidden (obsolete) |
Assignee | ||
Comment 19•9 years ago
|
||
Ignore comment 18 - that was bug 1234409's patch, which I accidentally landed with a mis-pasted bug number.
Comment hidden (Intermittent Failures Robot) |
Comment 21•9 years ago
|
||
Comment on attachment 8701357 [details] [diff] [review]
workaround v1
Review of attachment 8701357 [details] [diff] [review]:
-----------------------------------------------------------------
Sounds reasonable to me - thanks.
Attachment #8701357 -
Flags: review?(jfkthame) → review+
Assignee | ||
Comment 22•9 years ago
|
||
Comment 23•9 years ago
|
||
Comment 24•9 years ago
|
||
bugherder |
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
status-firefox46:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla46
Comment hidden (Intermittent Failures Robot) |
Assignee | ||
Comment 26•9 years ago
|
||
Looks like this worked! The brasstacks link in comment 25, looks like the only instances of this since the landing are on mozilla-aurora.
I'll backport this to aurora soon. (and I don't think we need this on beta, because beta has gtk3 disabled per bug 1227024 -- and this bug here only seems to be problematic in gtk3-enabled builds, as discussed on the broader bug 1223198.)
Assignee | ||
Updated•9 years ago
|
Flags: needinfo?(dholbert)
Assignee | ||
Comment 27•9 years ago
|
||
Backported to aurora: https://hg.mozilla.org/releases/mozilla-aurora/rev/839dd566125d
status-firefox45:
--- → fixed
Assignee | ||
Updated•9 years ago
|
Flags: needinfo?(dholbert)
You need to log in
before you can comment on or make changes to this bug.
Description
•