Closed
Bug 1204917
Opened 9 years ago
Closed 9 years ago
Remove nightly flag from Mobile Grid Tabs Tray work
Categories
(Firefox for Android Graveyard :: General, defect)
Tracking
(firefox44 fixed)
RESOLVED
FIXED
Firefox 44
Tracking | Status | |
---|---|---|
firefox44 | --- | fixed |
People
(Reporter: mhaigh, Assigned: sebastian)
References
Details
Attachments
(5 files)
(deleted),
text/x-review-board-request
|
Margaret
:
review+
|
Details |
(deleted),
text/x-review-board-request
|
Margaret
:
review+
|
Details |
(deleted),
text/x-review-board-request
|
Margaret
:
review+
|
Details |
(deleted),
text/x-review-board-request
|
Margaret
:
review+
|
Details |
(deleted),
text/x-review-board-request
|
Margaret
:
review+
|
Details |
In meta bug 1158277 we tracked some changes to put nightly flags around some work done for the mobile tabs tray. This bug is tracking the work needed to do to remove those nightly flags and let it ride the trains
Reporter | ||
Updated•9 years ago
|
Assignee: mhaigh → s.kaspari
Comment 1•9 years ago
|
||
Once we fix bug 1214602, let's get rid of this Nightly flag. Then we can create a separate feature-based flag for the "compact tabs" work, which is tracked in bug 1202861.
Assignee | ||
Comment 2•9 years ago
|
||
Bug 1204917 - Remove Nightly flag for back button in tabs tray. r?margaret
Attachment #8676189 -
Flags: review?(margaret.leibovic)
Assignee | ||
Comment 3•9 years ago
|
||
Bug 1204851 - Inline back button in tabs panel layout. r?margaret
Previously we used a ViewStub to only show the back button for some configurations. Now we
show the button always, so we can get rid of the ViewStub.
Attachment #8676190 -
Flags: review?(margaret.leibovic)
Assignee | ||
Comment 4•9 years ago
|
||
Bug 1204917 - Remove Nightly flag from full screen tabs tray. r?margaret
Attachment #8676191 -
Flags: review?(margaret.leibovic)
Assignee | ||
Comment 5•9 years ago
|
||
Bug 1204917 - Remove Nightly flag from tab thumbnail aspect ratio. r?margaret
Attachment #8676192 -
Flags: review?(margaret.leibovic)
Assignee | ||
Comment 6•9 years ago
|
||
Bug 1204917 - Remove Nightly flag: Always grow close button hit area. r?margaret
Attachment #8676193 -
Flags: review?(margaret.leibovic)
Assignee | ||
Comment 7•9 years ago
|
||
Assignee | ||
Comment 8•9 years ago
|
||
(In reply to Sebastian Kaspari (:sebastian) from comment #4)
> Created attachment 8676191 [details]
> MozReview Request: Bug 1204917 - Remove Nightly flag from full screen tabs
> tray. r?margaret
>
> Bug 1204917 - Remove Nightly flag from full screen tabs tray. r?margaret
This patch removes the Nightly flag and effectively short-circuits the height calculations by always returning the same size; hence we can remove even more code/logic. I filed bug 1216489 for that.
Comment 9•9 years ago
|
||
Comment on attachment 8676189 [details]
MozReview Request: Bug 1204917 - Remove Nightly flag for back button in tabs tray. r?margaret
https://reviewboard.mozilla.org/r/22615/#review20117
Attachment #8676189 -
Flags: review?(margaret.leibovic) → review+
Comment 10•9 years ago
|
||
Comment on attachment 8676190 [details]
MozReview Request: Bug 1204851 - Inline back button in tabs panel layout. r?margaret
https://reviewboard.mozilla.org/r/22617/#review20119
Attachment #8676190 -
Flags: review?(margaret.leibovic) → review+
Comment 11•9 years ago
|
||
Comment on attachment 8676191 [details]
MozReview Request: Bug 1204917 - Remove Nightly flag from full screen tabs tray. r?margaret
https://reviewboard.mozilla.org/r/22619/#review20121
Nice to see us remove all this logic :)
Attachment #8676191 -
Flags: review?(margaret.leibovic) → review+
Comment 12•9 years ago
|
||
Comment on attachment 8676192 [details]
MozReview Request: Bug 1204917 - Remove Nightly flag from tab thumbnail aspect ratio. r?margaret
https://reviewboard.mozilla.org/r/22621/#review20125
::: mobile/android/base/tabs/TabsPanelThumbnailView.java
(Diff revision 1)
> - return ThumbnailHelper.TOP_SITES_THUMBNAIL_ASPECT_RATIO;
Is there a bug on file to update our top sites to use this same aspect ratio as well?
Attachment #8676192 -
Flags: review?(margaret.leibovic) → review+
Updated•9 years ago
|
Attachment #8676193 -
Flags: review?(margaret.leibovic) → review+
Comment 13•9 years ago
|
||
Comment on attachment 8676193 [details]
MozReview Request: Bug 1204917 - Remove Nightly flag: Always grow close button hit area. r?margaret
https://reviewboard.mozilla.org/r/22623/#review20127
Assignee | ||
Comment 14•9 years ago
|
||
(In reply to :Margaret Leibovic from comment #12)
> Is there a bug on file to update our top sites to use this same aspect ratio
> as well?
I think I saw some mockups about that? But I don't know about a bug. Anthony?
Flags: needinfo?(alam)
Comment 15•9 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/6acf624d6a25
https://hg.mozilla.org/mozilla-central/rev/17250adb6819
https://hg.mozilla.org/mozilla-central/rev/809f7e707697
https://hg.mozilla.org/mozilla-central/rev/647db461d78d
Status: NEW → RESOLVED
Closed: 9 years ago
status-firefox44:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 44
Comment 17•9 years ago
|
||
Nope not yet. We intentionally decoupled it because the use-cases and problems of Top Sites and tabs tray are quite different.
I think we should look at Top sites separately and I've filed bug 1213140 for that.
Flags: needinfo?(alam)
Updated•4 years ago
|
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•