Closed Bug 1205288 Opened 9 years ago Closed 9 years ago

implement and test fetch spec changes for blob scheme with non-GET method

Categories

(Core :: DOM: Core & HTML, defect)

Product:
Core
Component:
DOM: Core & HTML
Version:
32 Branch
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla46
Tracking Flags:
Tracking Status
firefox46 --- fixed

People

(Reporter: bkelly, Assigned: dimi)

References

(Blocks 1 open bug)

Details

Attachments

(1 file, 1 obsolete file)

Patch - check non-GET for blob, with mochitest v2
(deleted), patch
dimi
: review+
Details | Diff | Splinter Review
See: https://github.com/whatwg/fetch/issues/125 Basically a non-GET Request for a blob: scheme URL should result in a NetworkError. Its possible we already implement this, but we should write a test. Preferably a WPT test.
I would like to take this bug.
Assignee: nobody → dlee
Status: NEW → ASSIGNED
Attached patch Patch - check non-GET for blob, with mochitest (obsolete) (deleted) — — Splinter Review
Hi Ben, I add a mochitest for this because there is already tests for fetch blob. please let me know if you prefer also adding a WPT.
Attachment #8704047 - Flags: review?(bkelly)
Comment on attachment 8704047 [details] [diff] [review] Patch - check non-GET for blob, with mochitest Review of attachment 8704047 [details] [diff] [review]: ----------------------------------------------------------------- Looks good. Thanks! Do you know if we check this in XHR as well?
Attachment #8704047 - Flags: review?(bkelly) → review+
(In reply to Ben Kelly [:bkelly] from comment #3) > Comment on attachment 8704047 [details] [diff] [review] > Patch - check non-GET for blob, with mochitest > > Review of attachment 8704047 [details] [diff] [review]: > ----------------------------------------------------------------- > > Looks good. Thanks! > > Do you know if we check this in XHR as well? No, i write a test and blob is load successfully with POST.
Update commit message. Also run try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=5da18a713b23
Attachment #8704047 - Attachment is obsolete: true
Attachment #8704530 - Flags: review+
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/4f4ef7073bb5
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
status-firefox46: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla46
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: