Closed
Bug 1205588
Opened 9 years ago
Closed 9 years ago
[Settings] Define MediaStorage using new syntax provided by Observable
Categories
(Firefox OS Graveyard :: Gaia::Settings, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: gasolin, Assigned: gasolin)
References
Details
Attachments
(1 file)
Separate from usb_storage_item in root panel. Define the module using new syntax
|
Assignee | |
Comment 1•9 years ago
|
||
|
|
Assignee | |
Comment 2•9 years ago
|
||
Comment on attachment 8662278 [details]
pull request redirect to github
Refactor to distill the MediaStorage module, so we can get volumeState and freeSize from the module and reuse them in sub panel.
Attachment #8662278 -
Flags: review?(yzenevich)
|
|
Assignee | |
Comment 3•9 years ago
|
||
Comment on attachment 8662278 [details]
pull request redirect to github
will postpone review until rebased
Attachment #8662278 -
Flags: review?(yzenevich)
|
|
Assignee | |
Comment 4•9 years ago
|
||
Comment on attachment 8662278 [details]
pull request redirect to github
Moving MediaStorage.volumeState and MediaStorage.freeSize to a separate module, so we can and reuse them in sub panel.
Attachment #8662278 -
Flags: review?(yzenevich)
|
||
Comment 5•9 years ago
|
||
Comment on attachment 8662278 [details]
pull request redirect to github
Looks good thanks (just one nit)!
Attachment #8662278 -
Flags: review?(yzenevich) → review+
|
|
Assignee | |
Comment 6•9 years ago
|
||
Thanks for review. Since the Debug syntax also exist on other place, I'll file bug 1206984, set as good first bug and put it in backlog to replace all that syntax.
|
|
Assignee | |
Comment 7•9 years ago
|
||
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•