Closed Bug 1205607 Opened 9 years ago Closed 9 years ago

[TV 2.5][Browser] The X icon should be a circle

Categories

(Firefox OS Graveyard :: Gaia::TV::Browser, defect, P4)

Product:
Firefox OS Graveyard
Component:
Gaia::TV::Browser
Platform:
ARM
Gonk (Firefox OS)
Type:
defect

Tracking

(blocking-b2g:2.5+, b2g-v2.5 fixed, b2g-master fixed)

Status:
VERIFIED FIXED
Project Flags:
blocking-b2g 2.5+
Tracking Flags:
Tracking Status
b2g-v2.5 --- fixed
b2g-master --- fixed

People

(Reporter: cynthiatang, Assigned: danhuang)

Details

(Whiteboard: [ft:conndevices][partner-cherry-pick][partner-blocker])

Attachments

(2 files)

Screen Shot
(deleted), image/png
Details
[gaia] danhuang1202:1205607_browser_input_field_delete_icon_should_be_circle > mozilla-b2g:master
(deleted), text/x-github-pull-request
yifan
: review+
jocheng
: approval-gaia-v2.5+
Details
Attached image Screen Shot (deleted) —
1. Launch Browser App 2. Go to a web page 3. Select "Bookmark this page" to Add this page to Bookmark 4. Press Up twice 5. Press Right Actual: - The animation is wrong. Please see the attachment. Expected: - The X icon should be cycle
Summary: [TV 2.5][Browser] The X icon should be cycle → [TV 2.5][Browser] The X icon should be a circle
QA Whiteboard: [COM=TV Browser]
Priority: -- → P3
Component: Gaia::TV → Gaia::TV::Browser
[Blocking Requested - why for this release]:
blocking-b2g: --- → 2.5?
Dan could you have a look on this one? Thanks!
Flags: needinfo?(dhuang)
set it a blocker but low priority.
blocking-b2g: 2.5? → 2.5+
Priority: P3 → P4
Assignee: nobody → dhuang
Comment on attachment 8702817 [details] [gaia] danhuang1202:1205607_browser_input_field_delete_icon_should_be_circle > mozilla-b2g:master Hi Yi-fan, please help review. This patch remove the border style when hover/focus to the delete icon. Thanks.
Flags: needinfo?(dhuang)
Attachment #8702817 - Flags: review?(yliao)
Comment on attachment 8702817 [details] [gaia] danhuang1202:1205607_browser_input_field_delete_icon_should_be_circle > mozilla-b2g:master Thanks! By the way this is not a gaia bug and cannot be reproduced on the latest Mulet. But the border property is indeed redundant.
Attachment #8702817 - Flags: review?(yliao) → review+
Thanks for the review. Merge in master: https://github.com/mozilla-b2g/gaia/commit/6c59e9bed969705e1b018053682cf1ba448ccf62
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Comment on attachment 8702817 [details] [gaia] danhuang1202:1205607_browser_input_field_delete_icon_should_be_circle > mozilla-b2g:master [Approval Request Comment] [Bug caused by] (feature/regressing bug #): Bug 1190158 [User impact] if declined: Icon hover and focus effect not align to UX spec. [Testing completed]: https://treeherder.mozilla.org/#/jobs?repo=gaia&revision=6c59e9bed969705e1b018053682cf1ba448ccf62 [Risk to taking this patch] (and alternatives if risky): None [String changes made]: None
Attachment #8702817 - Flags: approval-gaia-v2.5?
Whiteboard: [ft:conndevices] → [ft:conndevices][partner-cherry-pick][partner-blocker]
Comment on attachment 8702817 [details] [gaia] danhuang1202:1205607_browser_input_field_delete_icon_should_be_circle > mozilla-b2g:master Approved for TV 2.5
Attachment #8702817 - Flags: approval-gaia-v2.5? → approval-gaia-v2.5+
Verify this issue on the latest build. When bookmarking a web page, the X button shows a circle on the column of name. [Build Info] Environment: Simulator 2.5.20160215231509 gaia: https://github.com/mozilla-b2g/gaia/commit/b059a19c4cb615e16174735662199e6769cee393 gecko: https://hg.mozilla.org/releases/mozilla-b2g44_v2_5/rev/227c6d4926c154167a2214e123253f2c937e4106 mulet: https://hg.mozilla.org/releases/mozilla-b2g44_v2_5/rev/9d519d3bedacb7f5ce467f4c6bef7ff55ff3b0f3 [Build Info] Environment: Simulator 2.6.20160222133739 gaia: https://github.com/mozilla-b2g/gaia/commit/435a9320454ccc3ffdebff4d5d680f1254a15e26 gecko: https://hg.mozilla.org/mozilla-central/rev/a9e33d8c48b5ca93ca1937eba4220f681a0f05ec
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: