Closed Bug 1205676 Opened 9 years ago Closed 9 years ago

wpt service-workers tests unstable with e10s

Categories

(Testing :: web-platform-tests, defect)

Product:
Testing
Component:
web-platform-tests
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(e10s+, firefox44 fixed)

Status:
RESOLVED FIXED
Milestone:
mozilla44
Tracking Flags:
Tracking Status
e10s + ---
firefox44 --- fixed

People

(Reporter: jgraham, Assigned: baku)

References

(Blocks 1 open bug)

Details

Attachments

(2 files, 1 obsolete file)

patch
(deleted), patch
nsm
: review+
Details | Diff | Splinter Review
patch 2
(deleted), patch
bkelly
: review+
Details | Diff | Splinter Review
testing/web-platform/mozilla/meta/service-workers/service-worker/fetch-request-css-base-url.https.html.ini testing/web-platform/mozilla/meta/service-workers/service-worker/unregister-then-register-new-script.https.html.ini Disabled for now
We should investigate these failures as part of our test improvements on aurora if possible.
Blocks: ServiceWorkers-v1
Blocks: 1206011
No longer blocks: 1206011
Attached patch patch (obsolete) (deleted) — — Splinter Review
This is a first patch to fix the crash we have in this WPT: unregister-then-register-new-script.https.html
Attachment #8664846 - Flags: review?(nsm.nikhil)
Assignee: nobody → amarchesini
Status: NEW → ASSIGNED
Attached patch patch (deleted) — — Splinter Review
Attachment #8664846 - Attachment is obsolete: true
Attachment #8664846 - Flags: review?(nsm.nikhil)
Attachment #8664886 - Flags: review?(nsm.nikhil)
Comment on attachment 8664886 [details] [diff] [review] patch Review of attachment 8664886 [details] [diff] [review]: ----------------------------------------------------------------- ::: dom/workers/ServiceWorkerManager.cpp @@ +4633,5 @@ > ServiceWorkerManager::MaybeRemoveRegistration(ServiceWorkerRegistrationInfo* aRegistration) > { > MOZ_ASSERT(aRegistration); > nsRefPtr<ServiceWorkerInfo> newest = aRegistration->Newest(); > + if (!newest && HasScope(aRegistration->mPrincipal, aRegistration->mScope)) { While you are here, we also need to call aRegistration->Clear() before calling RemoveRegistration().
Attachment #8664886 - Flags: review?(nsm.nikhil) → review+
Keywords: leave-open
Attached patch patch 2 (deleted) — — Splinter Review
I cannot reproduce this issue anymore. I guess we can re-enable the test. Ben, what do you think?
Attachment #8668007 - Flags: review?(bkelly)
Comment on attachment 8668007 [details] [diff] [review] patch 2 Review of attachment 8668007 [details] [diff] [review]: ----------------------------------------------------------------- Ok. Note, I will need to change or remove this test in the near future.
Attachment #8668007 - Flags: review?(bkelly) → review+
Keywords: leave-open
https://hg.mozilla.org/mozilla-central/rev/188f0abba61a
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
status-firefox44: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla44
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: