James Graham [:jgraham] Reporter
	Description • 9 years ago

testing/web-platform/mozilla/meta/service-workers/service-worker/fetch-request-css-base-url.https.html.ini
testing/web-platform/mozilla/meta/service-workers/service-worker/unregister-then-register-new-script.https.html.ini

Disabled for now

	Ben Kelly [:bkelly, not reviewing]
	Comment 1 • 9 years ago

We should investigate these failures as part of our test improvements on aurora if possible.

	Kyle Huey (Exited; not receiving bugmail, old account, do not use)
	Comment 2 • 9 years ago

Related: https://github.com/slightlyoff/ServiceWorker/issues/746

	Andrea Marchesini [:baku] Assignee
	Comment 3 • 9 years ago

This is a first patch to fix the crash we have in this WPT: unregister-then-register-new-script.https.html

	Nikhil Marathe [:nsm] (No longer reading bugmail, please needinfo?)
	Comment 5 • 9 years ago

Comment on attachment 8664886 [details] [diff] [review]
patch

Review of attachment 8664886 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/workers/ServiceWorkerManager.cpp
@@ +4633,5 @@
>  ServiceWorkerManager::MaybeRemoveRegistration(ServiceWorkerRegistrationInfo* aRegistration)
>  {
>    MOZ_ASSERT(aRegistration);
>    nsRefPtr<ServiceWorkerInfo> newest = aRegistration->Newest();
> +  if (!newest && HasScope(aRegistration->mPrincipal, aRegistration->mScope)) {

While you are here, we also need to call aRegistration->Clear() before calling RemoveRegistration().

	Andrea Marchesini [:baku] Assignee
	Comment 6 • 9 years ago

https://treeherder.mozilla.org/#/jobs?repo=try&revision=9f5534b38eea

Let's see if it's green enough.

	Pulsebot
	Comment 7 • 9 years ago

https://hg.mozilla.org/integration/mozilla-inbound/rev/414686e07ce3

	Carsten Book [:Tomcat]
	Comment 8 • 9 years ago

https://hg.mozilla.org/mozilla-central/rev/414686e07ce3

	Andrea Marchesini [:baku] Assignee
	Comment 9 • 9 years ago

I cannot reproduce this issue anymore. I guess we can re-enable the test.
Ben, what do you think?

	Ben Kelly [:bkelly, not reviewing]
	Comment 10 • 9 years ago

Comment on attachment 8668007 [details] [diff] [review]
patch 2

Review of attachment 8668007 [details] [diff] [review]:
-----------------------------------------------------------------

Ok.  Note, I will need to change or remove this test in the near future.

	Pulsebot
	Comment 11 • 9 years ago

https://hg.mozilla.org/integration/mozilla-inbound/rev/188f0abba61a

	Carsten Book [:Tomcat]
	Comment 12 • 9 years ago

https://hg.mozilla.org/mozilla-central/rev/188f0abba61a