Closed
Bug 1205938
Opened 9 years ago
Closed 9 years ago
Enable fullscreen-api-race test on e10s
Categories
(Core :: DOM: Core & HTML, defect)
Core
DOM: Core & HTML
Tracking
()
RESOLVED
FIXED
mozilla49
People
(Reporter: xidorn, Assigned: xidorn)
References
(Blocks 2 open bugs)
Details
Attachments
(2 files)
No description provided.
Assignee | ||
Comment 1•9 years ago
|
||
Updated•9 years ago
|
Blocks: e10s-tests
tracking-e10s:
--- → +
Assignee | ||
Updated•9 years ago
|
Assignee | ||
Updated•9 years ago
|
No longer blocks: fullscreen-api
Assignee | ||
Updated•9 years ago
|
Flags: needinfo?(quanxunzhen)
Assignee | ||
Comment 2•9 years ago
|
||
Try push looks good: https://treeherder.mozilla.org/#/jobs?repo=try&revision=4d8b4c64969b
Flags: needinfo?(bugzilla)
Assignee | ||
Comment 3•9 years ago
|
||
This function is roughly copied from browser/base/content/test/general/head.js.
It has been widely used in browser chrome mochitests, and should be fine to
have it available to all mochitests via SimpleTest.
Review commit: https://reviewboard.mozilla.org/r/50305/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/50305/
Attachment #8748468 -
Flags: review?(jmaher)
Attachment #8748469 -
Flags: review?(bugs)
Assignee | ||
Comment 4•9 years ago
|
||
Review commit: https://reviewboard.mozilla.org/r/50307/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/50307/
Comment 5•9 years ago
|
||
Comment on attachment 8748469 [details]
MozReview Request: Bug 1205938 part 2 - Enable fullscreen-api-race test on e10s and OS X. r?smaug
https://reviewboard.mozilla.org/r/50307/#review47155
Attachment #8748469 -
Flags: review?(bugs) → review+
Comment 6•9 years ago
|
||
Comment on attachment 8748468 [details]
MozReview Request: Bug 1205938 part 1 - Add waitForCondition() function to SimpleTest. r?jmaher
https://reviewboard.mozilla.org/r/50305/#review47335
this looks like a simple move of a function into simpletest- I have no issues with it. Can we have a unittest for this? we have testing/tests/Harness_sanity/test_*.html to test some of the simpletest functions- it would be nice to get basic coverage- ok with a followup bug.
Attachment #8748468 -
Flags: review?(jmaher) → review+
Assignee | ||
Updated•9 years ago
|
Assignee: nobody → bugzilla
Comment 8•9 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/8710b9ecc282
https://hg.mozilla.org/mozilla-central/rev/7144610b5ce1
Status: NEW → RESOLVED
Closed: 9 years ago
status-firefox49:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla49
Updated•6 years ago
|
Component: DOM → DOM: Core & HTML
You need to log in
before you can comment on or make changes to this bug.
Description
•