Closed
Bug 1206123
Opened 9 years ago
Closed 9 years ago
Animation types aren't sent by old server, which breaks the new animation-inspector UI
Categories
(DevTools :: Inspector, defect)
DevTools
Inspector
Tracking
(firefox43 fixed)
RESOLVED
FIXED
Firefox 43
| Tracking | Status | |
|---|---|---|
| firefox43 | --- | fixed |
People
(Reporter: pbro, Assigned: pbro)
References
Details
Attachments
(1 file, 1 obsolete file)
|
(deleted),
patch
|
pbro
:
review+
|
Details | Diff | Splinter Review |
This isn't related to bug 1156757 which I just landed, but I think to bug 1180134.
A change I made in that bug broke backward compatibility in that the UI now relies on the existence of a particular animation player property (state.type) and uses it to construct a L10N key string.
However older servers don't send this property, and this breaks the UI.
|
Assignee | |
Comment 1•9 years ago
|
||
|
|
Assignee | |
Comment 2•9 years ago
|
||
And of course, I didn't see this coming because I haven't tested connecting to older server in a while...
|
||
Updated•9 years ago
|
Attachment #8662981 -
Flags: review?(bgrinstead) → review+
|
|
Assignee | |
Comment 3•9 years ago
|
||
Thanks Brian.
Modified commit message.
And pushed to try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=4960620776cb
Attachment #8662981 -
Attachment is obsolete: true
Attachment #8663311 -
Flags: review+
|
||
Comment 5•9 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
status-firefox43:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 43
|
||
Updated•6 years ago
|
Product: Firefox → DevTools
You need to log in
before you can comment on or make changes to this bug.
Description
•