We still have a few uses of mozL10n.DateTimeFormat in Communications code that should use Intl API.

Comment on attachment 8663216 [details] [gaia] zbraniecki:1206306-migrate-communications-to-intl-api > mozilla-b2g:master Borja, can you review this pls?

Comment on attachment 8663216 [details] [gaia] zbraniecki:1206306-migrate-communications-to-intl-api > mozilla-b2g:master Forwarding this to Francisco due to I'll be on PTO the following days. Thanks!

Comment on attachment 8663216 [details] [gaia] zbraniecki:1206306-migrate-communications-to-intl-api > mozilla-b2g:master This need also review from a dialer peer

Comment on attachment 8663216 [details] [gaia] zbraniecki:1206306-migrate-communications-to-intl-api > mozilla-b2g:master sure :)

Comment on attachment 8663216 [details] [gaia] zbraniecki:1206306-migrate-communications-to-intl-api > mozilla-b2g:master Looks good. I reviewed both the Dialer and Contacts parts, but I'm only qualified to review the Dialer parts. I left one nit in the Contacts section.

Comment on attachment 8663216 [details] [gaia] zbraniecki:1206306-migrate-communications-to-intl-api > mozilla-b2g:master Contacts part lgtm. Please fix the unit test errors before landing.

Ok. I fixed the tests. The reason they didn't work was because of timezones. I forced time comparisons to be in UTC and string comparisons to be local to the timezone in which the tests are run. It, as a side effect, fixed a bug which prevented people in US timezones from completing facebook connector tests :)

Commit: https://github.com/mozilla-b2g/gaia/commit/c1e6677a0f621c110146b13a4189660b001f1b80

Cherry-picked to nga branch: https://github.com/mozilla-b2g/gaia/commit/2725b5a06cbd8a7d5c881085f54546f854d54af6