Closed
Bug 1206979
Opened 9 years ago
Closed 9 years ago
Make FFmpeg PDM works with early version of libav
Categories
(Core :: Audio/Video: Playback, defect)
Tracking
()
RESOLVED
FIXED
mozilla44
People
(Reporter: jya, Assigned: jya)
References
Details
Attachments
(3 files)
(deleted),
patch
|
eflores
:
review+
lizzard
:
approval-mozilla-aurora+
|
Details | Diff | Splinter Review |
(deleted),
patch
|
eflores
:
review+
|
Details | Diff | Splinter Review |
(deleted),
patch
|
eflores
:
review+
|
Details | Diff | Splinter Review |
Right now, we distinguish the different version based on the libavformat soname (53, 54 or 55) which is almost useless in determining which version of ffmpeg is present.
version 54 is used for ffmpeg 1.2 to 2.2
libav 1.0 also uses 54
If we were to only support version 55 and later ;we would restrict ffmpeg version that works very well.
We should change our selection of ffmpeg/libav based on the libavcodec instead (as this is what we're using) and be able to check the minor revision.
Assignee | ||
Updated•9 years ago
|
Assignee: nobody → jyavenard
Assignee | ||
Comment 1•9 years ago
|
||
Rename ; as really this is the ultimate goal of this bug
Summary: Limit ffmpeg to version we know works → Enable FFMpeg by default
Assignee | ||
Comment 2•9 years ago
|
||
Attachment #8664073 -
Flags: review?(edwin)
Assignee | ||
Comment 3•9 years ago
|
||
And probably others. When multhreading decoding is enabled ; the frames dimensions were incorrectly set.
Attachment #8664074 -
Flags: review?(edwin)
Assignee | ||
Comment 4•9 years ago
|
||
Attachment #8664075 -
Flags: review?(edwin)
Attachment #8664073 -
Flags: review?(edwin) → review+
Attachment #8664074 -
Flags: review?(edwin) → review+
Attachment #8664075 -
Flags: review?(edwin) → review+
Assignee | ||
Comment 5•9 years ago
|
||
Assignee | ||
Updated•9 years ago
|
Summary: Enable FFMpeg by default → Make FFmpeg PDM works with early version of libav
Assignee | ||
Updated•9 years ago
|
Comment 7•9 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/97a161382b60
https://hg.mozilla.org/mozilla-central/rev/60560a4a7f41
https://hg.mozilla.org/mozilla-central/rev/0f7f4567efef
Status: NEW → RESOLVED
Closed: 9 years ago
status-firefox44:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla44
Assignee | ||
Comment 8•9 years ago
|
||
Comment on attachment 8664073 [details] [diff] [review]
P1. Add method to determine which version of libavcodec is available.
This is a request for all patches in this queue.
Approval Request Comment
[Feature/regressing bug #]: 1214943
[User impact if declined]: Decode failure with early libAV version (ubuntu 12.04)
[Describe test coverage new/current, TreeHerder]: In central for a few weeks.
[Risks and why]: Low, we properly handle an API discrepancy.
[String/UUID change made/needed]: None
Attachment #8664073 -
Flags: approval-mozilla-aurora?
Comment on attachment 8664073 [details] [diff] [review]
P1. Add method to determine which version of libavcodec is available.
More checks for compatibility for ffmpeg. OK to uplift to aurora.
Attachment #8664073 -
Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Comment 10•9 years ago
|
||
https://hg.mozilla.org/releases/mozilla-aurora/rev/8de5b42cda2d
https://hg.mozilla.org/releases/mozilla-aurora/rev/37cb06914ad6
https://hg.mozilla.org/releases/mozilla-aurora/rev/702f9f750869
status-firefox43:
--- → fixed
You need to log in
before you can comment on or make changes to this bug.
Description
•