Closed
Bug 1207485
Opened 9 years ago
Closed 9 years ago
[Input mgmt] Switch from mozChromeEvent/mozContentEvent to API methods
Categories
(Firefox OS Graveyard :: Gaia::System::Input Mgmt, defect)
Tracking
(b2g-v2.5 wontfix, b2g-master fixed)
RESOLVED
FIXED
People
(Reporter: timdream, Assigned: timdream)
References
Details
Attachments
(2 files)
See bug 1201407.
|
||
Comment 1•9 years ago
|
||
|
Assignee | |
Updated•9 years ago
|
|
|
Assignee | |
Comment 2•9 years ago
|
||
Comment on attachment 8664767 [details]
[gaia] timdream:input-mgmt-chrome-event > mozilla-b2g:master
Alberto,
Would you mind review one more patch related to this work? This patch grep the System app and transform the event listeners and the internal/external events into proper named events. There is one little syntax change at |evt.detail.choices| for <select> elements -- we no longer flatten that into a JSON string when sending that from Gecko to System.
Event now expects preventDefault() to be called when the request event is handled too.
I've changed TrustedUiValueSelector too but I suspect no one is actually using it. We can deal with it in bug 1210715.
Thanks!
Attachment #8664767 -
Flags: review?(apastor)
|
||
Comment 3•9 years ago
|
||
Comment on attachment 8664767 [details]
[gaia] timdream:input-mgmt-chrome-event > mozilla-b2g:master
I'm not too familiar with this code, but the changes make sense to me, and the tests are happy, so am I then :)
Attachment #8664767 -
Flags: review?(apastor) → review+
|
|
||
Comment 4•9 years ago
|
||
|
|
Assignee | |
Comment 5•9 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
|
|
Assignee | |
Comment 6•9 years ago
|
||
v2.5 revert due to bug 1222245:
https://github.com/timdream/gaia/commit/cf646c52bb947af28329b0a100df91d1b1f2a907
status-b2g-v2.5:
--- → wontfix
status-b2g-master:
--- → fixed
You need to log in
before you can comment on or make changes to this bug.
Description
•