Affected builds: - latest Nightly 44.0a1 - latest Developer Edition 43.0a2 Affected OS`s: - Mac OS X 10.10.5 - Ubuntu 14.04 32-bit - Windows 7 64-bit STR: 1. Start Firefox 2. Click Hello icon 3. Click on Share your screen button 4. Select Share tab twice Expected results: Share menu is closed after clicking it once. Actual results: After clicking twice the button will be inactive until conversation is restarted. Notes: 1. This issue was introduced after implementing the new design from bug 1184559.

Dan saw what bogdan did (without e10s) shell tried with e10s off in same version and it didn't happen.

e10s doesn't currently work so that's not an issue. Given that you can get into the inactive state so that you can't actually turn off screen sharing, I think we should be fixing this - especially as its very easy to hit because we're not closing the menu automatically.

This toggles the dropdown away, which is the same as what we do in other places.

Comment on attachment 8667847 [details] [diff] [review] Close the dropdown menu for sharing on Loop's conversation window as soon as an item is clicked, rather than leaving it open in a potentially confusing state. Review of attachment 8667847 [details] [diff] [review]: ----------------------------------------------------------------- ::: browser/components/loop/content/shared/js/views.jsx @@ +119,5 @@ > }, > > _handleShareTabs: function() { > this._startScreenShare("browser"); > + this.toggleDropdownMenu(); Why not `this.hideDropdownMenu()` ?

That'll be because I forgot that we had the hide function ;-)

Comment on attachment 8670222 [details] [diff] [review] Close the dropdown menu for sharing on Loop's conversation window as soon as an item is clicked, rather than leaving it open in a potentially confusing state. Review of attachment 8670222 [details] [diff] [review]: ----------------------------------------------------------------- LGTM, thanks!

Comment on attachment 8670222 [details] [diff] [review] Close the dropdown menu for sharing on Loop's conversation window as soon as an item is clicked, rather than leaving it open in a potentially confusing state. Approval Request Comment [Feature/regressing bug #]: Bug 1184559 - part of the visual refresh work for Hello [User impact if declined]: The user can get into a state where they can click the menu option twice in a row, then they can't turn off sharing without exiting the conversation. [Describe test coverage new/current, TreeHerder]: Landed in fx-team, has unit tests [Risks and why]: Low, minor change to menu functionality [String/UUID change made/needed]: None

Comment on attachment 8670222 [details] [diff] [review] Close the dropdown menu for sharing on Loop's conversation window as soon as an item is clicked, rather than leaving it open in a potentially confusing state. Fixes a recent regression, includes tests. Approved for uplift to aurora.