Closed
Bug 1208465
Opened 9 years ago
Closed 9 years ago
Disable using Direct2D 1.0 by default
Categories
(Core :: Graphics, defect)
Core
Graphics
Tracking
()
RESOLVED
FIXED
mozilla44
People
(Reporter: bas.schouten, Assigned: bas.schouten)
References
Details
Attachments
(2 files, 1 obsolete file)
(deleted),
patch
|
jrmuizel
:
review+
|
Details | Diff | Splinter Review |
(deleted),
patch
|
jrmuizel
:
review+
|
Details | Diff | Splinter Review |
We want to eventually remove support for Direct2D 1.0, let's disable using it by default in this train.
Attachment #8665975 -
Flags: review?(jmuizelaar)
Comment 1•9 years ago
|
||
Comment on attachment 8665975 [details] [diff] [review]
Disable using Direct2D 1.0 by default
Review of attachment 8665975 [details] [diff] [review]:
-----------------------------------------------------------------
I like
Attachment #8665975 -
Flags: review?(jmuizelaar) → review+
Assignee | ||
Comment 2•9 years ago
|
||
This adjusts a bunch of test framework expectations.
Attachment #8665975 -
Attachment is obsolete: true
Attachment #8666761 -
Flags: review?(jmuizelaar)
Assignee | ||
Comment 3•9 years ago
|
||
Attachment #8667919 -
Flags: review?(jmuizelaar)
Comment 4•9 years ago
|
||
Comment on attachment 8666761 [details] [diff] [review]
Part 2: Disable using Direct2D 1.0 by default v2
Review of attachment 8666761 [details] [diff] [review]:
-----------------------------------------------------------------
::: testing/web-platform/meta/2dcontext/fill-and-stroke-styles/2d.gradient.radial.outside3.html.ini
@@ +4,5 @@
> expected:
> if not debug and (os == "win") and (version == "5.1.2600") and (processor == "x86") and (bits == 32): FAIL
> if debug and (os == "win") and (version == "5.1.2600") and (processor == "x86") and (bits == 32): FAIL
> + if not debug and (os == "win") and (version == "6.1.7601") and (processor == "x86") and (bits == 32): FAIL
> + if debug and (os == "win") and (version == "6.1.7601") and (processor == "x86") and (bits == 32): FAIL
Bad indenting
::: testing/web-platform/meta/2dcontext/path-objects/2d.path.arcTo.shape.curve1.html.ini
@@ +3,5 @@
> [arcTo() curves in the right kind of shape]
> expected:
> if not debug and (os == "win") and (version == "5.1.2600") and (processor == "x86") and (bits == 32): FAIL
> if debug and (os == "win") and (version == "5.1.2600") and (processor == "x86") and (bits == 32): FAIL
> + if (os == "win") and (version == "6.1.7601") and (processor == "x86") and (bits == 32): FAIL
same
::: testing/web-platform/meta/2dcontext/path-objects/2d.path.arcTo.shape.curve2.html.ini
@@ +3,5 @@
> [arcTo() curves in the right kind of shape]
> expected:
> if not debug and (os == "win") and (version == "5.1.2600") and (processor == "x86") and (bits == 32): FAIL
> if debug and (os == "win") and (version == "5.1.2600") and (processor == "x86") and (bits == 32): FAIL
> + if (os == "win") and (version == "6.1.7601") and (processor == "x86") and (bits == 32): FAIL
Indentation looks wrong here.
Attachment #8666761 -
Flags: review?(jmuizelaar) → review+
Updated•9 years ago
|
Attachment #8667919 -
Flags: review?(jmuizelaar) → review+
Comment 6•9 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/2ef0bdb65dbf
https://hg.mozilla.org/mozilla-central/rev/c3ad832a28ec
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
status-firefox44:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla44
Comment 7•9 years ago
|
||
a huge list of improvements/regressions on talos:
http://alertmanager.allizom.org:8080/alerts.html?rev=c3ad832a28ecfbf14f1e7c3d2b3e9f90c015b35a&table=1
Bas has confirmed this is expected, can we figure out if the test machines need to be updated at all?
If it's possible to update Windows 7 machines to SP1, we'd be able to start using D2D1.1 there as well, rather than just on Windows 8.
Comment 9•9 years ago
|
||
Release Note Request (optional, but appreciated)
[Why is this notable]: Font rendering can change and people don't like the result:
https://www.reddit.com/r/firefox/comments/4312zk/firefox_44_font_feels_very_anemic/
https://www.reddit.com/r/firefox/comments/4328ur/fonts_too_thin_with_the_new_update/
[Suggested wording]:
Support for Direct2D 1.0 has been dropped. This can change the font rendering on systems that don't support Direct2D 1.1 (Windows Vista and Windows 7 without the Platform Update). Windows 7 users can install the Platform Update [https://www.microsoft.com/en-ca/download/details.aspx?id=36805] to re-enable Direct2D support.
relnote-firefox:
--- → ?
Done. Added to Fx44 release notes.
You need to log in
before you can comment on or make changes to this bug.
Description
•