Handle MAP replies from Gaia and pass the results to BluetoothMapSmsManager

Hi Wesley, Please nominate this bug as 2.2r feature.

Change BluetoothMapRequestHandle from DOMRequest to Promise.

Comment on attachment 8671390 [details] [diff] [review] Bug 1208492 - Handle MAP replies from Gaia and pass the results to BluetoothMapSmsManager Review of attachment 8671390 [details] [diff] [review]: ----------------------------------------------------------------- r=me with comment addressed. ::: dom/bluetooth/bluedroid/BluetoothMapSmsManager.h @@ +85,5 @@ > // By defualt SMS/MMS is default supported > static const int SDP_SMS_MMS_INSTANCE_ID = 0; > > static BluetoothMapSmsManager* Get(); > bool Listen(); nit: newline after this line @@ +100,5 @@ > + > + /** > + * Reply message-listing object to the *IPC* 'messageslisting' > + * > + * @param aActor [in] a blob actor containing the vCard objects bMessage objects @@ +104,5 @@ > + * @param aActor [in] a blob actor containing the vCard objects > + * @param aMasId [in] MAS id > + * @param aNewMessage [in] indicate whether there are unread messages > + * @param aTimestamp [in] time stamp > + * @param aSize [in] total numbers of messages total number @@ +116,5 @@ > + > + /** > + * Reply messages-listing object to the *in-process* 'messageslisting' request > + * > + * @param aBlob [in] a blob contained the vCard objects containing the bMessage objects @@ +120,5 @@ > + * @param aBlob [in] a blob contained the vCard objects > + * @param aMasId [in] MAS id > + * @param aNewMessage [in] indicate whether there are unread messages > + * @param aTimestamp [in] time stamp > + * @param aSize [in] total numbers of messages total number @@ +133,5 @@ > + /** > + * Reply bMessage object to the *IPC* 'getmessage' request. > + * > + * @param aActor [in] a blob actor containing the bMessage object > + * @param aMasId [in] the number of vCard indexes in the blob bMessage indexes @@ +143,5 @@ > + > + /** > + * Reply bMessage to the *in-process* 'getmessage' request. > + * > + * @param aBlob [in] a blob contained the bMessage object containing @@ +144,5 @@ > + /** > + * Reply bMessage to the *in-process* 'getmessage' request. > + * > + * @param aBlob [in] a blob contained the bMessage object > + * @param aMasId [in] the number of vCard indexes in the blob bMessage indexes. @@ +155,5 @@ > + /** > + * Reply to the *IPC* 'setmessage' request. > + * > + * @param aMasId [in] MAS id > + * @param aStatus [in] success or fail nit: failure, to be both nouns @@ +166,5 @@ > + /** > + * Reply to the *in-process* 'sendmessage' request. > + * > + * @param aMasId [in] MAS id > + * @param aStatus [in] success or fail failure @@ +177,5 @@ > + /** > + * Reply to the *in-process* 'messageupdate' request. > + * > + * @param aMasId [in] MAS id > + * @param aStatus [in] success or fail failure ::: dom/bluetooth/bluedroid/BluetoothServiceBluedroid.cpp @@ +1726,5 @@ > + long aMasId, > + const nsAString& aFolderlists, > + BluetoothReplyRunnable* aRunnable) > +{ > +// TODO: Implement for future Email support nit: indention ::: dom/bluetooth/bluedroid/BluetoothServiceBluedroid.h @@ +216,5 @@ > + bool aStatus, > + BluetoothReplyRunnable* aRunnable); > + > + virtual void > + ReplyToMapSendMessage(long aMasId, bool aStatus, nit: to be consistent, break these parameters to two lines. @@ +220,5 @@ > + ReplyToMapSendMessage(long aMasId, bool aStatus, > + BluetoothReplyRunnable* aRunnable); > + > + virtual void > + ReplyToMapMessageUpdate(long aMasId, bool aStatus, Ditto. ::: dom/bluetooth/bluez/BluetoothDBusService.h @@ +185,5 @@ > > virtual void > ReplyTovCardListing(Blob* aBlob, > uint16_t aPhonebookSize, > + BluetoothReplyRunnable* aRunnable) override; nit: newline after this line. ::: dom/bluetooth/common/BluetoothService.h @@ +379,5 @@ > + bool aStatus, > + BluetoothReplyRunnable* aRunnable) = 0; > + > + virtual void > + ReplyToMapSendMessage(long aMasId, bool aStatus, nit: to be consistent, break these parameters to two lines. @@ +383,5 @@ > + ReplyToMapSendMessage(long aMasId, bool aStatus, > + BluetoothReplyRunnable* aRunnable) = 0; > + > + virtual void > + ReplyToMapMessageUpdate(long aMasId, bool aStatus, Ditto. ::: dom/bluetooth/ipc/BluetoothServiceChildProcess.h @@ +186,5 @@ > > virtual void > ReplyTovCardListing(Blob* aBlob, > uint16_t aPhonebookSize, > BluetoothReplyRunnable* aRunnable) override; nit: newline after this line. @@ +226,5 @@ > + bool aStatus, > + BluetoothReplyRunnable* aRunnable) override; > + > + virtual void > + ReplyToMapSendMessage(long aMasId, bool aStatus, nit: to be consistent, break these parameters to two lines. @@ +230,5 @@ > + ReplyToMapSendMessage(long aMasId, bool aStatus, > + BluetoothReplyRunnable* aRunnable) override; > + > + virtual void > + ReplyToMapMessageUpdate(long aMasId, bool aStatus, Ditto.

Thanks, Ben. https://treeherder.mozilla.org/#/jobs?repo=b2g-inbound&revision=96508aad02d1

Sigh! v2.2r doesn't support BluetoothVoidReplyRunnable with Promise. Damn it. Since Bug 1184017 landed to v2.2r. I guess adding Promise support would be easier for future life.

Set ni flag to prepare v2.2r patch.

shawn this still need a patch :)

Need to back port: Bug 1032755, bug 1016196.

(In reply to Shawn Huang [:shawnjohnjr] from comment #18) > Need to back port: Bug 1032755, bug 1016196. After checking the dependency, only the patch of bug 1016196 is required.

(In reply to Carsten Book [:Tomcat] from comment #17) > shawn this still need a patch :) I've resolved the dependency. Please help to uplift.

(In reply to Shawn Huang [:shawnjohnjr] from comment #22) > (In reply to Carsten Book [:Tomcat] from comment #17) > > shawn this still need a patch :) > I've resolved the dependency. Please help to uplift. sorry anytime Shawn! Landed: https://hg.mozilla.org/releases/mozilla-b2g37_v2_2r/rev/7c1770e79d78 https://hg.mozilla.org/releases/mozilla-b2g37_v2_2r/rev/8175f99236d0

(In reply to Carsten Book [:Tomcat] from comment #23) > (In reply to Shawn Huang [:shawnjohnjr] from comment #22) > > (In reply to Carsten Book [:Tomcat] from comment #17) > > > shawn this still need a patch :) > > I've resolved the dependency. Please help to uplift. > > sorry anytime Shawn! Landed: > > https://hg.mozilla.org/releases/mozilla-b2g37_v2_2r/rev/7c1770e79d78 > https://hg.mozilla.org/releases/mozilla-b2g37_v2_2r/rev/8175f99236d0 This appears to have broken ICS builds on 2.2r: https://treeherder.mozilla.org/logviewer.html#?job_id=11606&repo=mozilla-b2g37_v2_2r

Comment on attachment 8679327 [details] [diff] [review] Bug 1208492 - Fix ICS emulator build break (v2.2r) Review of attachment 8679327 [details] [diff] [review]: ----------------------------------------------------------------- LGTM.